Fixes flakey TestNodeWatcher test#2168
Merged
c-kruse merged 1 commit intoskupperproject:mainfrom Jun 25, 2025
Merged
Conversation
TestNodeWatcher seemed to be failing due to a race between the testing goroutine exercising the fake k8s client (creating and deleting resources) and the goroutine of the informer syncronizing its cache and invoking handlers/callbacks based on the current state of a resources. This change introduces blocking in the test goroutine - expecting callbacks for the initial resource state to run before continuing to update resources. Signed-off-by: Christian Kruse <christian@c-kruse.com>
Contributor
Author
|
Part of #2164 |
c-kruse
force-pushed
the
testfix-testnodewatcher-race
branch
from
c1cb766 to
8d8a7d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestNodeWatcher seemed to be failing due to a race between the testing goroutine exercising the fake k8s client (creating and deleting resources) and the goroutine of the informer syncronizing its cache and invoking handlers/callbacks based on the current state of a resources. This change introduces blocking in the test goroutine - expecting callbacks for the initial resource state to run before continuing to update resources.