Disable line breaks in base64 encoded strings#188
Open
libohad-dev wants to merge 1 commit intoskuro:developfrom
Open
Disable line breaks in base64 encoded strings#188libohad-dev wants to merge 1 commit intoskuro:developfrom
libohad-dev wants to merge 1 commit intoskuro:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out that
(base64-encode-string STRING)breaks long lines with newlines by default. The resulting string is invalid and ignored by the diagram generation code (tested in'servermode using the official Docker image).According to the function's documentation, you have to set the second optional argument
NO-LINE-BREAKto prevent that.