feat: add support for NUMERIC type #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….0 (googleapis#186) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | minor | `5.2.0` -> `5.3.0` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-spanner).
* Removes specific error message checking, as the backend may change these without prior notice. * Removes warnings regarding deprected ExpectedException class. * Refactored to reuse the same table for most tests to reduce execution time. Fixes googleapis#175
* tests: attempt to fix timeouts of ITBackup * fix: fix second timeout * tests: add operation name to log * tests: add additional logging to ITBackup * tests: cancel long-running backup operations before test
* chore: generate the README via synth.py * restore transport section
PiperOrigin-RevId: 306557455 Source-Author: Google APIs <[email protected]> Source-Date: Tue Apr 14 18:46:18 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: ab5d07c2883026eec395d73ff59a17f4ad0153db Source-Link: googleapis/googleapis@ab5d07c
🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
* updated CHANGELOG.md [ci skip] * updated README.md [ci skip] * updated versions.txt [ci skip] * updated samples/pom.xml [ci skip] * updated google-cloud-spanner-bom/pom.xml [ci skip] * updated samples/snapshot/pom.xml [ci skip] * updated google-cloud-spanner/pom.xml [ci skip] * updated grpc-google-cloud-spanner-admin-database-v1/pom.xml [ci skip] * updated grpc-google-cloud-spanner-admin-instance-v1/pom.xml [ci skip] * updated grpc-google-cloud-spanner-v1/pom.xml [ci skip] * updated pom.xml [ci skip] * updated proto-google-cloud-spanner-admin-database-v1/pom.xml [ci skip] * updated proto-google-cloud-spanner-admin-instance-v1/pom.xml [ci skip] * updated proto-google-cloud-spanner-v1/pom.xml [ci skip] * updated samples/install-without-bom/pom.xml [ci skip] * updated samples/snippets/pom.xml [ci skip] Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Currently `restoreDatabase`, `updateBackup` and `deleteBackup` are final methods. For some internal tests, we need to override these methods so ideally they shouldn't be final.
SpannerRetryHelperTest.testExceptionWithRetryInfo could sometimes fail on some environments. I have not been able to reproduce it locally, but one possible reason for the failure could be truncation when converting from nanoseconds to milliseconds. Now both the timeout and the verification use nanosecond precision. This change also removes all uses of hamcres in this test file. Fixes googleapis#200
Closing a Spanner client means that all resources that have been returned by the client are no longer valid, including all DatabaseClients and corresponding session pools. This will cause errors for any other process that might still want to use these resources. This change marks when and by which call stack a Spanner client is closed, and includes that in any subsequent IllegalStateException that is returned to any process that tries to use the resources that have been returned by the Spanner client. This makes it easier to track down where and when a Spanner client is closed by accident.
* fix: Partitioned DML timeout was not always respected Setting a timeout value for Partitioned DML would not be respected if the timeout value was higher than the timeout value set for the ExecuteSql RPC on the SpannerStub. Lower timeout values would be respected. Fixes googleapis#199 * fix: add ignored changes + InternalApi * tests: add test for retry on UNAVAILABLE
🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
The PartitionedDML stub was not closed when Spanner was closed. In addition, Spanner did not wait for the channels to actually close, causing some test cases to (sometimes) log a warning that the channel had not been closed.
🤖 I have created a release \*beep\* \*boop\* --- ## [1.55.0](https://www.github.com/googleapis/java-spanner/compare/v1.54.0...v1.55.0) (2020-05-19) ### Features * mark when a Spanner client is closed ([googleapis#198](https://www.github.com/googleapis/java-spanner/issues/198)) ([50cb174](https://www.github.com/googleapis/java-spanner/commit/50cb1744e7ede611758d3ff63b3df77a1d3682eb)) ### Bug Fixes * make it possible to override backups methods ([googleapis#195](https://www.github.com/googleapis/java-spanner/issues/195)) ([2d19c25](https://www.github.com/googleapis/java-spanner/commit/2d19c25ba32847d116194565e67e1b1276fcb9f8)) * Partitioned DML timeout was not always respected ([googleapis#203](https://www.github.com/googleapis/java-spanner/issues/203)) ([13cb37e](https://www.github.com/googleapis/java-spanner/commit/13cb37e55ddfd1ff4ec22b1dcdc20c4832eee444)), closes [googleapis#199](https://www.github.com/googleapis/java-spanner/issues/199) * partitionedDml stub was not closed ([googleapis#213](https://www.github.com/googleapis/java-spanner/issues/213)) ([a2d9a33](https://www.github.com/googleapis/java-spanner/commit/a2d9a33fa31f7467fc2bfbef5a29c4b3f5aea7c8)) * reuse clientId for invalidated databases ([googleapis#206](https://www.github.com/googleapis/java-spanner/issues/206)) ([7b4490d](https://www.github.com/googleapis/java-spanner/commit/7b4490dfb61fbc81b5bd6be6c9a663b36b5ce402)) * use nanos to prevent truncation errors ([googleapis#204](https://www.github.com/googleapis/java-spanner/issues/204)) ([a608460](https://www.github.com/googleapis/java-spanner/commit/a60846043dc0ca47e1970d8ab99380b6d725c7a9)), closes [googleapis#200](https://www.github.com/googleapis/java-spanner/issues/200) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.3.1 ([googleapis#190](https://www.github.com/googleapis/java-spanner/issues/190)) ([ad41a0d](https://www.github.com/googleapis/java-spanner/commit/ad41a0d4b0cc6a2c0ae0611c767652f64cfb2fb7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
….0 (googleapis#223) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | minor | `5.3.0` -> `5.4.0` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-spanner).
) * fix: PDML retry settings were not applied for aborted tx The PartitionedDML retry settings were only applied for the RPC, and not for the generic retryer that would retry the PDML transaction if it was aborted by Spanner. This could cause long-running PDML transactions to fail with an Aborted exception. Fixes googleapis#199 * fix: add ignored diff to clirr
🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
…onfig to v0.6.0 (googleapis#228) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | minor | `0.5.0` -> `0.6.0` | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v0.6.0`](https://togithub.com/googleapis/java-shared-config/blob/master/CHANGELOG.md#​060-httpswwwgithubcomgoogleapisjava-shared-configcomparev050v060-2020-05-19) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v0.5.0...v0.6.0) ##### Features - add new configuration necessary to support auto-value ([#​136](https://www.github.com/googleapis/java-shared-config/issues/136)) ([c14689b](https://www.github.com/googleapis/java-shared-config/commit/c14689b8791c173687f719d73156a989aedd7ba6)) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-spanner).
Some tests relied on an environment variable having been set for a default project id credentials file. This change removes this dependency by setting an explicit project id and credentials instance.
* tests: add additional tests for client ids * fix: close Spanner to prevent resource leak
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/e1a3e905-8b24-4bda-895c-1dffe544b2cb/targets PiperOrigin-RevId: 309824146 Source-Link: googleapis/googleapis@e0f9d9e
* updated CHANGELOG.md [ci skip] * updated README.md [ci skip] * updated versions.txt [ci skip] * updated samples/pom.xml [ci skip] * updated samples/install-without-bom/pom.xml [ci skip] * updated samples/snippets/pom.xml [ci skip] * updated google-cloud-spanner-bom/pom.xml [ci skip] * updated pom.xml [ci skip] * updated google-cloud-spanner/pom.xml [ci skip] * updated grpc-google-cloud-spanner-admin-database-v1/pom.xml [ci skip] * updated grpc-google-cloud-spanner-admin-instance-v1/pom.xml [ci skip] * updated grpc-google-cloud-spanner-v1/pom.xml [ci skip] * updated proto-google-cloud-spanner-admin-database-v1/pom.xml [ci skip] * updated proto-google-cloud-spanner-admin-instance-v1/pom.xml [ci skip] * updated proto-google-cloud-spanner-v1/pom.xml [ci skip] * updated samples/snapshot/pom.xml Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
…to v1.58.0 (googleapis#322) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:google-cloud-spanner](https://togithub.com/googleapis/java-spanner) | minor | `1.57.0` -> `1.58.0` | --- ### Release Notes <details> <summary>googleapis/java-spanner</summary> ### [`v1.58.0`](https://togithub.com/googleapis/java-spanner/blob/master/CHANGELOG.md#​1580-httpswwwgithubcomgoogleapisjava-spannercomparev1570v1580-2020-07-07) [Compare Source](https://togithub.com/googleapis/java-spanner/compare/v1.57.0...v1.58.0) ##### Features - add async api ([#​81](https://www.github.com/googleapis/java-spanner/issues/81)) ([462839b](https://www.github.com/googleapis/java-spanner/commit/462839b625e58e235581b8ba10b398e1d222eaaf)) - support setting compression option ([#​192](https://www.github.com/googleapis/java-spanner/issues/192)) ([965e95e](https://www.github.com/googleapis/java-spanner/commit/965e95e70ccd9c62abd6513b0011aab136e48e26)) ##### Bug Fixes - set default values for streaming retry ([#​316](https://www.github.com/googleapis/java-spanner/issues/316)) ([543373b](https://www.github.com/googleapis/java-spanner/commit/543373b22336be72b10026fda9f0b55939ab94b4)) ##### Performance Improvements - use streaming RPC for PDML ([#​287](https://www.github.com/googleapis/java-spanner/issues/287)) ([df47c13](https://www.github.com/googleapis/java-spanner/commit/df47c13a4c00bdf5e6eafa01bbb64c12a96d7fb8)) ##### Dependencies - update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.2 ([#​315](https://www.github.com/googleapis/java-spanner/issues/315)) ([3d6fb9f](https://www.github.com/googleapis/java-spanner/commit/3d6fb9fd7dc6b2b5b2ff9935228701ac795c9167)) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-spanner).
* test: change system-test setup against emulator Use Docker image instead of manually downloading the emulator binary and running it. * chore: cleanup unusued script file * fix: use latest version of docker image
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/8f9b2ee6-9eab-4b87-867c-98d5f8fc5313/targets - [ ] To automatically regenerate this PR, check this box.
…sions - protobuf v3.12.1 - rules_go v0.23.0 - gazelle v0.21.0 - gapic-generator-go v0.14.1 (googleapis#263) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/e66d5b32-5d3a-4216-853d-260a1b0f526f/targets - [ ] To automatically regenerate this PR, check this box. PiperOrigin-RevId: 313460921 Source-Link: googleapis/googleapis@c4e3701
* updated versions.txt [ci skip] * updated samples/pom.xml [ci skip] * updated samples/install-without-bom/pom.xml [ci skip] * updated samples/snippets/pom.xml [ci skip] * updated google-cloud-spanner-bom/pom.xml [ci skip] * updated google-cloud-spanner/pom.xml [ci skip] * updated grpc-google-cloud-spanner-admin-database-v1/pom.xml [ci skip] * updated grpc-google-cloud-spanner-admin-instance-v1/pom.xml [ci skip] * updated grpc-google-cloud-spanner-v1/pom.xml [ci skip] * updated pom.xml [ci skip] * updated proto-google-cloud-spanner-admin-database-v1/pom.xml [ci skip] * updated proto-google-cloud-spanner-admin-instance-v1/pom.xml [ci skip] * updated proto-google-cloud-spanner-v1/pom.xml [ci skip] * updated samples/snapshot/pom.xml Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
…onfig to v0.9.2 (googleapis#308) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | minor | `0.8.1` -> `0.9.2` | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v0.9.2`](https://togithub.com/googleapis/java-shared-config/blob/master/CHANGELOG.md#​092-httpswwwgithubcomgoogleapisjava-shared-configcomparev091v092-2020-07-02) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v0.9.1...v0.9.2) ### [`v0.9.1`](https://togithub.com/googleapis/java-shared-config/blob/master/CHANGELOG.md#​091-httpswwwgithubcomgoogleapisjava-shared-configcomparev090v091-2020-07-01) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v0.9.0...v0.9.1) ### [`v0.9.0`](https://togithub.com/googleapis/java-shared-config/blob/master/CHANGELOG.md#​090-httpswwwgithubcomgoogleapisjava-shared-configcomparev081v090-2020-06-25) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v0.8.1...v0.9.0) ##### Features - add ignore rule for javax annotations to handle error in java11 ([#​171](https://www.github.com/googleapis/java-shared-config/issues/171)) ([cd635ad](https://www.github.com/googleapis/java-shared-config/commit/cd635ad6e8e5d71ac3a30e7656eb788027f1c370)) ##### [0.8.1](https://www.github.com/googleapis/java-shared-config/compare/v0.8.0...v0.8.1) (2020-06-15) ##### Bug Fixes - bump flatten plugin version to fix missing version in profile section issue ([#​159](https://www.github.com/googleapis/java-shared-config/issues/159)) ([5b34939](https://www.github.com/googleapis/java-shared-config/commit/5b349399a590b589718b7049f66c82ee38742372)) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-spanner).
If an AsyncResultSet was paused directly after receiving its last row and then cancelled while in paused mode, there was a small chance that the callback would not be called a last time to indicate to the user that the result set had been cancelled. Updates googleapis#327
A transaction could in some circumstances be retried after an abort using the previous transaction id. This would cause the retry to abort directly as well, and then start a new transaction. This extra loop has now been removed. Fixes googleapis#327
Adds configuration files in kokoro to run sample tests in java 8 and java 11. These were added in the continuous, nightly and presubmit builds.
* chore: changes without context
autosynth cannot find the source of changes triggered by earlier changes in this
repository, or by version upgrades to tools such as linters.
* chore: set Ruby namespace in proto options
PiperOrigin-RevId: 316144276
Source-Author: Google APIs <[email protected]>
Source-Date: Fri Jun 12 11:38:22 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: b5653ef55579186841dee924592248d821902a12
Source-Link: googleapis/googleapis@b5653ef
* chore: fully qualify response type in longrunning_operation.info for CreateBackup in the same fashion as all other longrunning operations
PiperOrigin-RevId: 320022685
Source-Author: Google APIs <[email protected]>
Source-Date: Tue Jul 7 11:19:52 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 4d8706453bf6016ebf1bb241d78b4dc58c92064d
Source-Link: googleapis/googleapis@4d87064
* fix: migrate spanner/database/v1 to grpc_service_config
PiperOrigin-RevId: 320114022
Source-Author: Google APIs <[email protected]>
Source-Date: Tue Jul 7 20:27:27 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: d8354750a5fe21173832ab9a1f2ce6348cd27d83
Source-Link: googleapis/googleapis@d835475
* fix: migrate spanner/instance/v1 to grpc_service_config
PiperOrigin-RevId: 320114042
Source-Author: Google APIs <[email protected]>
Source-Date: Tue Jul 7 20:27:36 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 8bbefeffb4c91fd34e1729bbc51dfc136557d88d
Source-Link: googleapis/googleapis@8bbefef
* fix: migrate spanner/v1 to grpc_service_config
PiperOrigin-RevId: 320114059
Source-Author: Google APIs <[email protected]>
Source-Date: Tue Jul 7 20:27:48 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: c29c4c519667a51c0e2cfddda9c3a66be77bdf38
Source-Link: googleapis/googleapis@c29c4c5
* fix: apply SpannerOptionsTest patch (googleapis#332)
Co-authored-by: Noah Dietz <[email protected]>
* fix: check if emulator is running if env var is set * fix: only test for emulator if no channel provider is set
Uses the same pattern as it is being done in the bigquery kokoro config files: java<version>-samples.cfg.
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/fa501585-95fa-4c4d-9062-c23b3406d7ec/targets - [ ] To automatically regenerate this PR, check this box. PiperOrigin-RevId: 321058159 Source-Link: googleapis/googleapis@59f97e6
* fix: respect PDML timeout when using streaming RPC * fix: check for negative or zero deadline * fix: subtract from original timeout to get remaining
|
Integration tests are now here: olavloite#1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
NUMERICdata type.