adding mermaid dia for deepseek.py #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a Mermaid diagram to visualize the DeepSeek model architecture, providing a visual representation of the model's components and data flow.
- Adds a new Mermaid diagram file illustrating the DeepSeek model architecture with dense blocks, MoE blocks, and FFN internals
- Updates the README to reference the architecture diagram image
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| deepseek/images/deepseek_arch.mermaid | New Mermaid diagram showing model architecture with dense/MoE blocks and data flow |
| deepseek/README.md | Adds reference to the architecture diagram image in the documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| - PUNCT high in Expert 1 → punctuation + quotation boundaries → this expert probably activates for dialogue and sentence ends. | ||
|
|
||
| ### Model Architecture diagram | ||
|  |
There was a problem hiding this comment.
The README references 'deepseek_arch.png' but the added file is 'deepseek_arch.mermaid'. Either the image reference should point to the correct file extension or a PNG version needs to be generated from the Mermaid diagram.
Suggested change
|  | |
| ```mermaid | |
| %% See deepseek_arch.mermaid for the source diagram | |
| %% Paste the contents of deepseek_arch.mermaid below | |
| [PASTE THE CONTENTS OF deepseek_arch.mermaid HERE] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding architecture diagram for deepseek.py