Skip to content
This repository was archived by the owner on Apr 18, 2023. It is now read-only.

Remove 'round-places' argument from 'OasisMarketMakerKeeper'#133

Open
adamjsawicki wants to merge 1 commit intosky-ecosystem:masterfrom
adamjsawicki:remove-round-places-from-arg-parser
Open

Remove 'round-places' argument from 'OasisMarketMakerKeeper'#133
adamjsawicki wants to merge 1 commit intosky-ecosystem:masterfrom
adamjsawicki:remove-round-places-from-arg-parser

Conversation

@adamjsawicki
Copy link
Copy Markdown

@adamjsawicki adamjsawicki commented Jan 23, 2020

Fixes #2.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #133 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
+ Coverage    17.8%   17.81%   +<.01%     
==========================================
  Files          41       41              
  Lines        4257     4256       -1     
==========================================
  Hits          758      758              
+ Misses       3499     3498       -1
Impacted Files Coverage Δ
market_maker_keeper/oasis_market_maker_keeper.py 29.32% <ø> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d85e4a...849fca6. Read the comment docs.

@adamjsawicki
Copy link
Copy Markdown
Author

@Reverendus can this merge?

@ghost
Copy link
Copy Markdown

ghost commented Feb 3, 2020

@swixx I think all these projects have new maintainers already.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do price rounding better in sai_maker_otc.py

2 participants