Conversation
…id` and `participants` are not required args any more with py3.10+
…k_type` BREAKING CHANGE, but probably not crucial and resolves confusion around internal type keyword and parameter
…ible from opencode
GenericMapperMessageFactory are optional
ntamas
approved these changes
Jan 22, 2026
Member
ntamas
left a comment
There was a problem hiding this comment.
Made a few changes here and there on my own, it was easier than to go through the commenting phase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started this branch to introduce
tyand possibly resolve all errors pointed out by it. Halfway through. Could be merged to main and rebased to that to reduce review noise, but branch should not be deleted yet. There are still ~60 errors/warnings left out of the initial ~900, but it is tiring, I do not know when I will have time to continue...