Skip to content

Comments

Fix ignored patterns was not applied to window tool properly#80

Merged
skydoves merged 1 commit intomainfrom
wintool/ignored-patterns
Dec 10, 2025
Merged

Fix ignored patterns was not applied to window tool properly#80
skydoves merged 1 commit intomainfrom
wintool/ignored-patterns

Conversation

@skydoves
Copy link
Owner

@skydoves skydoves commented Dec 10, 2025

Fix ignored patterns was not applied to window tool properly (#74)

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Ignored parameters now display as stable in the tool window
    • Composable skippability is recalculated after applying ignore patterns
    • Composables with only ignored unstable parameters now correctly show skippable status
    • Enhanced visibility of composable signatures while respecting ignore pattern settings

✏️ Tip: You can customize this high-level summary in your review settings.

@skydoves skydoves self-assigned this Dec 10, 2025
@coderabbitai
Copy link

coderabbitai bot commented Dec 10, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request modifies the tool window's handling of ignored type patterns by implementing a two-phase processing pipeline. Instead of filtering out ignored parameters, they are now marked as stable, and composable skippability is recalculated based on the processed parameters before applying filter rules (ALL, SKIPPABLE, UNSKIPPABLE).

Changes

Cohort / File(s) Summary
Documentation & Configuration
compose-stability-analyzer-idea/CHANGELOG.md, compose-stability-analyzer-idea/build.gradle.kts
Added version 0.6.2 changeNotes documenting improvements to ignored type pattern handling in the tool window, including stable display of ignored parameters and recalculated composable skippability.
Tool Window Logic
compose-stability-analyzer-idea/src/main/kotlin/com/skydoves/compose/stability/idea/toolwindow/StabilityToolWindow.kt
Replaced simple filter-map flow with two-phase processing: (1) mark parameters matching ignore patterns as stable without removal, (2) recompute each composable's skippability based on processed parameters, then apply filtering on the processed list.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

  • The main functional change in StabilityToolWindow.kt involves a two-phase processing pipeline with parameter transformation and skippability recalculation logic—requires careful verification that the skippability calculation correctly identifies restartable composables and properly handles edge cases (e.g., composables with only ignored unstable parameters).
  • Ensure the processed parameters list correctly preserves all ignored parameters while marking them stable, and verify that the filtering logic on the processed list produces expected results for each filter mode (ALL, SKIPPABLE, UNSKIPPABLE).

Possibly related PRs

Poem

🐰 Patterns ignored, yet patterns remain,
Now marked stable, no need to refrain,
Skippability reborn through two-phase flow,
Tool window wisdom—watch composables grow! 🌱

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch wintool/ignored-patterns

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9b11da4 and dc49c84.

📒 Files selected for processing (3)
  • compose-stability-analyzer-idea/CHANGELOG.md (1 hunks)
  • compose-stability-analyzer-idea/build.gradle.kts (1 hunks)
  • compose-stability-analyzer-idea/src/main/kotlin/com/skydoves/compose/stability/idea/toolwindow/StabilityToolWindow.kt (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@skydoves skydoves merged commit d762692 into main Dec 10, 2025
10 of 11 checks passed
@skydoves skydoves deleted the wintool/ignored-patterns branch December 10, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant