You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Should this branch work as is on Angular 10? The currently released version yields console warnings that it's a CommonJS dependency, so I was hoping this branch would remedy that, but this is all new to me. I tried: npm install --save NathanWalker/ngx-google-places-autocomplete#feat/angular-10
What should my imports be updated to? I currently have import { GooglePlaceModule } from 'ngx-google-places-autocomplete'; which yields:
TS2307: Cannot find module 'ngx-google-places-autocomplete' or its corresponding type declarations.
Is it just that types are missing? I see index.d.ts referenced but I don't see any declaration files.
Any help appreciated.
@ccondrup i'm having this warning too, it'd be great to convert all CommonJS modules to ECMAScript modules, since CommonJS obstructs tree-shaking of modules. @skynet2, is there any chance to fix this, sir?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.