Allow an array of string in ComponentRestrictions#81
Open
DeepSnowNeeL wants to merge 2 commits intoskynet2:masterfrom
Open
Allow an array of string in ComponentRestrictions#81DeepSnowNeeL wants to merge 2 commits intoskynet2:masterfrom
DeepSnowNeeL wants to merge 2 commits intoskynet2:masterfrom
Conversation
As the google doc says, it should be allowed to have an array here. See https://developers.google.com/maps/documentation/javascript/reference/places-autocomplete-service#ComponentRestrictions
Author
|
I just added the optionals on the Btw, origin is not documented on https://developers.google.com/maps/documentation/javascript/reference/places-widget#AutocompleteOptions maybe it should be removed from the |
|
👍🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the google doc says, it should be allowed to have an array here.
See https://developers.google.com/maps/documentation/javascript/reference/places-autocomplete-service#ComponentRestrictions
Why I'm proposing this change:
With the new updates to the language server, I added
"angularCompilerOptions":{ "strictTemplates":true }to my tsconfig which now throws an error like :Since I had in my code : (screenshot to see the reason of the error)
