make items of options parameter optional#96
Open
lakson wants to merge 1 commit intoskynet2:masterfrom
Open
Conversation
|
@lakson , my fear here would be if there was some conflict and package-lock and node_modeles are removed it will cause an issue. This worked like a charm. import { Options } from 'ngx-google-places-autocomplete/objects/options/options'; options = { |
|
This thing was adjusted in new package, in general class was omitted and used interface instead. Because of inactivity of this package, I created my own package which is fully compatible with this one, code base was used from this package and adjusted to new coding standards. You can try: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: options not working with Angular 11 #91
i make all variables of options class optionnal by adding ? behind