Conversation
…tatic analysis errors. Couldn't upgrade the testbench and phpunit yet, as they failed on the most recent versions
📜 You will endure this loss, and learn from it. |
Owner
Author
|
|
Replying to: @skywarth Original message
🕯️ Elusive, evasive, persistent. Righteous traits for a rogue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5 +/- ##
============================================
+ Coverage 96.13% 96.16% +0.03%
- Complexity 104 107 +3
============================================
Files 12 13 +1
Lines 336 339 +3
============================================
+ Hits 323 326 +3
Misses 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closed
|
🕯️ Wealth beyond measure, awarded to the brave and the foolhardy alike. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial upgrade to PHP 8.1 requisite, installing phpstan and fixing static analysis errors. Couldn't upgrade the testbench and phpunit yet, as they failed on the most recent versions.
Upgrade to PHP 8.3 and latter versions will be handled separately, though this should fix all the deprecation notices in #4 regardless.
Scheduler went under massive changes, need to tackle the following TODOs first:
masterbranch to add warning about later Laravel versionsUpdate the documentation according to the new syntax. Beware that interface API has changed and CRON now allows for secondly runs.(Will be tackled on Laravel12.xupgrade)Update the tests(Will be tackled on Laravel12.xupgrade)