Skip to content

Conversation

@jarospisak-unity
Copy link
Contributor

@jarospisak-unity jarospisak-unity commented Oct 1, 2025

This PR adds support for title argument in the CreateChannelCanvas method.

Closes #1482.

@nlopes
Copy link
Collaborator

nlopes commented Oct 26, 2025

Hi @jarospisak-unity. As it stands this is a breaking change and I'd rather not add breaking changes if they can be avoided at all.

One way is simply to add a method that allows to pass options. This pattern already exists in other parts of the codebase. Happy for you to give it a go if you're ok to do so, alternatively, I'll come back to this soon-ish.

func (api *Client) CreateChannelCanvasWithOptions(channel string, options
  ...CreateChannelCanvasOption) (string, error) {
      return api.CreateChannelCanvasWithOptionsContext(context.Background(), channel,
  options...)
  }
[...]

@jarospisak-unity
Copy link
Contributor Author

@nlopes thanks for the feedback, I wasn't aware of that pattern. I'll refactor this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for title parameter in conversations.canvases.create method

2 participants