Merge pull request #120 from dblock/remove-gifs

Removed GIFs.

Author: dblock

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 #### 0.12.2 (Next)
 
+* [#120](https://github.com/slack-ruby/slack-ruby-bot-server/pull/120): Removed GIFs - [@dblock](https://github.com/dblock).
 * Your contribution here.
 
 #### 0.12.1 (2020/5/16)

Gemfile

@@ -40,3 +40,5 @@ end
 group :test do
   gem 'slack-ruby-danger', '~> 0.1.0', require: false
 end
+
+gem 'slack-ruby-bot', github: 'slack-ruby/slack-ruby-bot'

lib/slack-ruby-bot-server/ext/activerecord/slack-ruby-bot/commands/base.rb

@@ -9,7 +9,7 @@ def invoke(client, data)
         rescue StandardError => e
           logger.info "#{name.demodulize.upcase}: #{client.owner}, #{e.class}: #{e}"
           logger.debug e.backtrace.join("\n")
-          client.say(channel: data.channel, text: e.message, gif: 'error')
+          client.say(channel: data.channel, text: e.message)
           true
         end
       end

lib/slack-ruby-bot-server/ext/mongoid/slack-ruby-bot/commands/base.rb

@@ -8,12 +8,12 @@ def invoke(client, data)
           _invoke client, data
         rescue Mongoid::Errors::Validations => e
           logger.info "#{name.demodulize.upcase}: #{client.owner}, error - #{e.document.class}, #{e.document.errors.to_hash}"
-          client.say(channel: data.channel, text: e.document.errors.first[1], gif: 'error')
+          client.say(channel: data.channel, text: e.document.errors.first[1])
           true
         rescue StandardError => e
           logger.info "#{name.demodulize.upcase}: #{client.owner}, #{e.class}: #{e}"
           logger.debug e.backtrace.join("\n")
-          client.say(channel: data.channel, text: e.message, gif: 'error')
+          client.say(channel: data.channel, text: e.message)
           true
         end
       end

sample_apps/sample_app_activerecord/commands/help.rb

@@ -13,7 +13,7 @@ class Help < SlackRubyBot::Commands::Base
   EOS
   def self.call(client, data, _match)
     client.say(channel: data.channel, text: [HELP, SlackRubyBotServer::INFO].join("\n"))
-    client.say(channel: data.channel, gif: 'help')
+    client.say(channel: data.channel)
     logger.info "HELP: #{client.owner}, user=#{data.user}"
   end
 end

sample_apps/sample_app_activerecord/spec/commands/help_spec.rb

@@ -8,7 +8,7 @@
   let(:message_hook) { SlackRubyBot::Hooks::Message.new }
   it 'default' do
     expect(client).to receive(:say).with(channel: 'channel', text: [Help::HELP, SlackRubyBotServer::INFO].join("\n"))
-    expect(client).to receive(:say).with(channel: 'channel', gif: 'help')
+    expect(client).to receive(:say).with(channel: 'channel')
     message_hook.call(client, Hashie::Mash.new(channel: 'channel', text: "#{SlackRubyBot.config.user} help"))
   end
 end

sample_apps/sample_app_mongoid/commands/help.rb

@@ -13,7 +13,7 @@ class Help < SlackRubyBot::Commands::Base
   EOS
   def self.call(client, data, _match)
     client.say(channel: data.channel, text: [HELP, SlackRubyBotServer::INFO].join("\n"))
-    client.say(channel: data.channel, gif: 'help')
+    client.say(channel: data.channel)
     logger.info "HELP: #{client.owner}, user=#{data.user}"
   end
 end

sample_apps/sample_app_mongoid/spec/commands/help_spec.rb

@@ -8,7 +8,7 @@
   let(:message_hook) { SlackRubyBot::Hooks::Message.new }
   it 'default' do
     expect(client).to receive(:say).with(channel: 'channel', text: [Help::HELP, SlackRubyBotServer::INFO].join("\n"))
-    expect(client).to receive(:say).with(channel: 'channel', gif: 'help')
+    expect(client).to receive(:say).with(channel: 'channel')
     message_hook.call(client, Hashie::Mash.new(channel: 'channel', text: "#{SlackRubyBot.config.user} help"))
   end
 end

spec/ext/activerecord/commands_spec.rb

@@ -11,7 +11,7 @@
       end
 
       it 'responds to channel with exception message' do
-        expect(client).to receive(:say).with(channel: 'channel', text: 'mock error', gif: 'error')
+        expect(client).to receive(:say).with(channel: 'channel', text: 'mock error')
         message_hook.call(client, Hashie::Mash.new(text: 'raising exception', channel: 'channel', user: 'user'))
       end
     end

spec/ext/mongoid/commands_spec.rb

@@ -11,7 +11,7 @@
       end
 
       it 'responds to channel with exception message' do
-        expect(client).to receive(:say).with(channel: 'channel', text: 'mock error', gif: 'error')
+        expect(client).to receive(:say).with(channel: 'channel', text: 'mock error')
         message_hook.call(client, Hashie::Mash.new(text: 'raising exception', channel: 'channel', user: 'user'))
       end
     end
@@ -28,7 +28,7 @@ class MockDocument
       end
 
       it 'responds to channel with exception message' do
-        expect(client).to receive(:say).with(channel: 'channel', text: "undefined method `mock_id' for #{mock_document.inspect}", gif: 'error')
+        expect(client).to receive(:say).with(channel: 'channel', text: "undefined method `mock_id' for #{mock_document.inspect}")
         message_hook.call(client, Hashie::Mash.new(text: 'raising exception', channel: 'channel', user: 'user'))
       end
     end