*_id methods may be supplied with all sensible options#560
Merged
dblock merged 1 commit intoslack-ruby:masterfrom Jun 26, 2025
Merged
*_id methods may be supplied with all sensible options#560dblock merged 1 commit intoslack-ruby:masterfrom
dblock merged 1 commit intoslack-ruby:masterfrom
Conversation
63d4548 to
bf84668
Compare
bf84668 to
5c91fe4
Compare
Pull Request Test Coverage Report for Build 15907224173Details
💛 - Coveralls |
dblock
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to supply all sensible options to the list calls underlying
conversations_idandusers_id. A couple considerations were made while creating this code:users_listwithinclude_localeis useless since we will immediately throw away the added locale data when plucking and returning the user's id. As such, it has been excluded.team_idis not prefixed to avoid collision with parameters intended for parent calls (i.e. is notid_team_id). In fact, using the sameteam_idwith the parent calls seems desirable; it means one cannot look up a user in one team and then look up conversations from that user id in another with e.g.