fix: remove nonnull assertions in favor of type narrowing #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimeg
requested review from
WilliamBergamin,
misscoded,
mwbrooks and
srtaalej
Contributor
WilliamBergamin
left a comment
WilliamBergamin
left a comment
There was a problem hiding this comment.
Nice work 💯 left non blocking comments
| * @see {@link ../shortcuts/sample-shortcut.ts} | ||
| * @see {@link https://www.typescriptlang.org/docs/handbook/2/narrowing.html} | ||
| */ | ||
| if (body.view?.type !== 'modal') { |
Contributor
There was a problem hiding this comment.
what do you think about adding a logger.warn rather then a comment 🤔 ?
Member
Author
There was a problem hiding this comment.
For now I'll hold off on this since other actions aren't configured at the moment - I believe modal actions are the only view this app receives from!
Comment on lines
-12
to
-15
| // biome-ignore lint/style/noNonNullAssertion: view may be undefined, depending on the source of this action(did it come from an action within a conversation message or a modal?). take care! | ||
| view_id: body.view!.id, | ||
| // biome-ignore lint/style/noNonNullAssertion: view may be undefined, depending on the source of this action(did it come from an action within a conversation message or a modal?). take care! | ||
| hash: body.view!.hash, |
WilliamBergamin
approved these changes
Oct 21, 2025
srtaalej
approved these changes
Oct 22, 2025
Member
Author
|
@WilliamBergamin @srtaalej Kind thanks for these reviews! I'm hoping we can continue to refine the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Summary
This PR removes non-null assertions in favor of type narrowing when updating the modal.
Reviewers
After building and running this app, run the shortcut then update the modal with the following slash command:
We hope all works the same!
Notes
This action responds to just the shortcut view AFAICT! Otherwise I think we'd be erroring here 😉
Requirements