chore: update to latests Deno and CLI standards#33
Merged
WilliamBergamin merged 8 commits intomainfrom May 29, 2025
Merged
Conversation
WilliamBergamin
added
the
update
zimeg
approved these changes
May 22, 2025
Member
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
@WilliamBergamin LGTM! 🦕 ✨
One comment around tests, but I'm already so thankful that a test was added for this sample. Thank you! 🎁
Member
|
📝 I made a suggested change to the title in slack-samples/deno-message-translator#48 that might be applicable here too, but I'm not certain at the best phrasing... Something similar might be nice to use here to so we can find when these |
Co-authored-by: Eden Zimbelman <zim@o526.net>
WilliamBergamin
changed the title
WilliamBergamin
changed the title
zimeg
approved these changes
May 28, 2025
Member
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
🏆 @WilliamBergamin LGTM! I'm now a big fan of inlining these for fast reads 📚 ✨
Comment on lines
-31
to
+30
| "test": "deno fmt --check && deno lint && deno test --allow-read --allow-none" | ||
| "test": "deno fmt --check && deno lint && deno test --allow-read" |
Member
There was a problem hiding this comment.
🧠 Great way to make sure we're actually running tests!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change (place an x in the [ ] that applies)
Summary
This PR aims to update the sample to the Deno 2 standards and the latest CLI standards.
slack.jsonto.slack/hooks.jsonimport-map.jsontodeno.jsoncRequirements (place an x in each [ ] that applies)