Get rid of the configurator workflow design pattern#47
Merged
Conversation
zimeg
approved these changes
Feb 19, 2025
Member
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
LGTM! I found the app setup convenient with these steps handled by the event trigger - this is dang neat 👾
One comment related to all_resources in the reaction_added_trigger.ts might be alright to remove too, but this isn't a blocker at all. These translating threads interesting as is! 👏 ✨
Comment on lines
+150
to
+152
| Once this app's bot user is added to a channel, adding reactions such as `:jp:` | ||
| and `:fr:` results in posting translation results of the target message as | ||
| replies in its thread. |
Member
There was a problem hiding this comment.
Nice! This is a really slick setup 🚢 💨 ✨
Comment on lines
-45
to
-49
| // configurator | ||
| "triggers:read", | ||
| "triggers:write", | ||
| "channels:join", | ||
| "groups:read", |
| */ | ||
| export default Manifest({ | ||
| name: "DeepL Translator", | ||
| name: "DeepL Translator 2", |
Member
There was a problem hiding this comment.
Lots of great improvements all throughout! 🚀
Contributor
Author
|
@zimeg Thanks for the swift review as always and great catch on the comments! I've removed them, so let me merge this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change (place an x in the [ ] that applies)
Summary
This pull request significantly simplifies the way to run this app. Users no longer need to manage the list of channel IDs within a workflow trigger.
Requirements (place an x in each [ ] that applies)