Fix 403 by migrating DeepL auth from legacy body auth to header auth#59
Open
dokokanokafka wants to merge 1 commit intoslack-samples:mainfrom
Open
Fix 403 by migrating DeepL auth from legacy body auth to header auth#59dokokanokafka wants to merge 1 commit intoslack-samples:mainfrom
dokokanokafka wants to merge 1 commit intoslack-samples:mainfrom
Conversation
|
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Kido Haruhi <k***@e***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated. |
Author
|
以前本リポジトリで相談させていただいたものです。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景 / Background
403が発生していた。 / Translation workflow was failing with403.原因 / Cause
auth_keyを request body で送る方式だった。 / The previous implementation sent DeepLauth_keyin the request body.Authorization: DeepL-Auth-Key <key>の header 認証方式 が前提。 / Current DeepL authentication expects header-based auth viaAuthorization: DeepL-Auth-Key <key>.403になる。 / Keeping the legacy method results in403.改善内容 / Improvements
auth_keyの body 送信を廃止し、Authorizationヘッダへ移行。 / Removed bodyauth_keyand moved authentication toAuthorizationheader.DEEPL_AUTH_KEYの前後空白・引用符を除去してから使用するよう改善。 / Added normalization forDEEPL_AUTH_KEY(trim + quote stripping).:fx判定)。 / Stabilized Free/Pro endpoint selection (:fxdetection).テスト / Testing
deno fmt functions/translate.ts functions/translate_test.tsdeno test functions/translate_test.tsok | 5 passed | 0 failed