Skip to content

chore: update to latests Deno and CLI standards #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
WilliamBergamin merged 2 commits into from
May 29, 2025
Merged

chore: update to latests Deno and CLI standards #44

WilliamBergamin merged 2 commits into from
May 29, 2025

Conversation

@WilliamBergamin
Copy link
Contributor

@WilliamBergamin WilliamBergamin commented May 23, 2025

Type of change

  • New sample
  • New feature
  • Bug fix
  • Documentation

Summary

This PR aims to update the sample to the Deno 2 standards and the latest CLI standards.

  • Move content of slack.json to .slack/hooks.json
  • Remove dependency on mock-fetch/
  • Import from JSR as much as possible
  • Move imports from import-map.json to deno.jsonc

Requirements

  • I’ve checked my submission against the Samples Checklist to ensure it complies with all standards
  • I have ensured the changes I am contributing align with existing patterns and have tested and linted my code
  • I've read and agree to the Code of Conduct

@WilliamBergamin WilliamBergamin requested a review from zimeg May 23, 2025 18:44
@WilliamBergamin WilliamBergamin self-assigned this May 23, 2025
@WilliamBergamin WilliamBergamin added the update PR only - an update or maintenance is being made to an existing app label May 23, 2025
zimeg
zimeg approved these changes May 27, 2025
View reviewed changes
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WilliamBergamin Working hard in this PR! Thanks for making improvements to the health of code while bringing this sample up to date 🙏 ✨

functions/send_time_off_request_to_manager/blocks_test.ts
{ type: "section", text: { type: "mrkdwn", text: "*Reason:* N/A" } },
];
const blocks = await timeOffRequestHeaderBlocks({
const blocks = timeOffRequestHeaderBlocks({
Copy link
Member

@zimeg zimeg May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Great catch!

@WilliamBergamin WilliamBergamin merged commit 1434378 into main May 29, 2025
2 checks passed
@WilliamBergamin WilliamBergamin deleted the update-with-new-standards branch May 29, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zimeg zimeg zimeg approved these changes

Assignees

@WilliamBergamin WilliamBergamin

Labels

update PR only - an update or maintenance is being made to an existing app

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WilliamBergamin @zimeg