Skip to content

Conversation

@filmaj
Copy link
Contributor

@filmaj filmaj commented Nov 26, 2024

This PR bumps socket-mode to to 2.0.3-rc.1, which includes a proposed fix for slackapi/node-slack-sdk#2094 via slackapi/node-slack-sdk#2099.

The intention is to surface the proposed fix via a bolt-js 4.1.2-rc.1 release candidate so that the community may more easily evaluate the fix.

@filmaj filmaj added draft A pull request that is currently in active development and not yet ready for review dependencies Pull requests that update a dependency file labels Nov 26, 2024
@filmaj filmaj added this to the 4.1.2 milestone Nov 26, 2024
@filmaj filmaj self-assigned this Nov 26, 2024
@codecov
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.59%. Comparing base (fa14b38) to head (63d9af1).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2347   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files          36       36           
  Lines        7472     7472           
  Branches      653      653           
=======================================
  Hits         6919     6919           
  Misses        545      545           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@salesforce-cla
Copy link

salesforce-cla bot commented Dec 5, 2024

Thanks for the contribution! Before we can merge this, we need @filmaj to sign the Salesforce Inc. Contributor License Agreement.

@zimeg
Copy link
Member

zimeg commented Dec 5, 2024

@salesforce-cla - thinking this might be due to rebased happenings. Planning to keep this PR open while testing continues, but will open another one once the tagged releases are made 🙏

@zimeg
Copy link
Member

zimeg commented Dec 17, 2024

The changes of @slack/[email protected] were included in the @slack/[email protected] release - closing this PR 🙏 ✨

@zimeg zimeg closed this Dec 17, 2024
@zimeg zimeg deleted the bolt-4.1.2rc branch December 17, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:missing dependencies Pull requests that update a dependency file draft A pull request that is currently in active development and not yet ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants