Skip to content

Conversation

@lukegalbraithrussell
Copy link
Contributor

Summary

This provides some edits for #2597

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.37%. Comparing base (09cb24f) to head (cec8fdb).
⚠️ Report is 1 commits behind head on zimeg-docs-getting-started-cli.

Additional details and impacted files
@@                       Coverage Diff                       @@
##           zimeg-docs-getting-started-cli    #2598   +/-   ##
===============================================================
  Coverage                           93.37%   93.37%           
===============================================================
  Files                                  37       37           
  Lines                                7581     7581           
  Branches                              667      667           
===============================================================
  Hits                                 7079     7079           
  Misses                                497      497           
  Partials                                5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukegalbraithrussell LGTM! I'm amazed at the seemingly quick calls made to improve the writing so much 🙏 ✨

I left a few comments of thoughts and links and organization alike. Please feel free to ignore most or all.

We can also prefer edits on this branch instead of #2597 if that'd be best? 🤖

The sample app still needs to be published with some CLI changes, but for now we should keep these edits around! 🚀

Look around, add an app icon and description, and then let's start configuring your app. 🔩

#### Installing the app
#### Installing the app {#installing-the-app}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖

Comment on lines +7 to +9
* set up your local environment,
* create a new Slack app,
* and enable it to listen for and respond to messages within a Slack workspace.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧠 ✨


:::

#### Prerequisites
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓 Good call for fast linking ahead!

</Tabs>

Your app should let you know that it's up and running. 🎉
Your app should let you know that it's up and running. It's not actually listening for anything though. Let's change that.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆 Thanks for including this!

<TabItem value="socket-mode" label="Socket Mode">

```javascript
```javascript title="app.js"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL! 🤯

@zimeg
Copy link
Member

zimeg commented Jul 31, 2025

☝️ Failing tests might require a rebase with main in #2597 and here. We can perhaps merge these into a single PR for additional review soon as well?

The referenced sample app and CLI changes are in progress but after those land the guide will be in a good place. 🤖

@lukegalbraithrussell
Copy link
Contributor Author

ah right yes, pls merge this into your PR whenever it is convenient for you!

@zimeg zimeg added the docs M-T: Documentation work only label Aug 1, 2025
@zimeg
Copy link
Member

zimeg commented Aug 1, 2025

@lukegalbraithrussell Will do, of course with all credit of these changes and a huge thanks to you 🙏 ✨

@zimeg zimeg marked this pull request as ready for review August 1, 2025 22:19
@zimeg zimeg merged commit 6e398cd into zimeg-docs-getting-started-cli Aug 1, 2025
19 checks passed
@zimeg zimeg deleted the luke-docs-getting-started-cli branch August 1, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs M-T: Documentation work only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants