-
Notifications
You must be signed in to change notification settings - Fork 419
ci: perform sample and example app tests on regression schedules #2743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2743 +/- ##
=======================================
Coverage 93.44% 93.44%
=======================================
Files 37 37
Lines 7675 7675
Branches 669 669
=======================================
Hits 7172 7172
Misses 498 498
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗣️ A quick note for wonderful reviewers!
| working-directory: ./sample | ||
| run: npx tsc | ||
| notifications: | ||
| name: Regression notifications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 note: We have a matching step in the adjacent "ci-build" workflow but for now I didn't combine these testing steps:
bolt-js/.github/workflows/ci-build.yml
Line 44 in e2aa743
| name: Regression notifications |
👁️🗨️ ramble: Of course open to adjusting this however seems best!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair for now 💯
|
@WilliamBergamin @srtaalej Thanks both for the reviews! I'll hold off on merging this as CI is failing now, but I think exists in #2744 🚀 |
|
@WilliamBergamin @srtaalej The encouragement to better CI inspires me - thanks for the kind reviews! 👾 ✨ I hope we don't find notifications in channel too often but I will merge this in hopes that we might. |
Summary
This PR adds a schedule regression check and manual workflow dispatch to the samples compilation testing workflow.
Hopes to catch issues in included dependencies as soon as possible 👾 ✨
Requirements