Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Dec 15, 2025

Summary

This PR adds a schedule regression check and manual workflow dispatch to the samples compilation testing workflow.

Hopes to catch issues in included dependencies as soon as possible 👾 ✨

Requirements

@zimeg zimeg self-assigned this Dec 15, 2025
@zimeg zimeg requested a review from a team as a code owner December 15, 2025 18:59
@zimeg zimeg added semver:patch tests M-T: Testing work only github_actions Pull requests that update GitHub Actions code labels Dec 15, 2025
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.44%. Comparing base (01a1d6f) to head (a24912d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2743   +/-   ##
=======================================
  Coverage   93.44%   93.44%           
=======================================
  Files          37       37           
  Lines        7675     7675           
  Branches      669      669           
=======================================
  Hits         7172     7172           
  Misses        498      498           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member Author

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗣️ A quick note for wonderful reviewers!

working-directory: ./sample
run: npx tsc
notifications:
name: Regression notifications
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 note: We have a matching step in the adjacent "ci-build" workflow but for now I didn't combine these testing steps:

name: Regression notifications

👁️‍🗨️ ramble: Of course open to adjusting this however seems best!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair for now 💯

@zimeg
Copy link
Member Author

zimeg commented Dec 15, 2025

@WilliamBergamin @srtaalej Thanks both for the reviews! I'll hold off on merging this as CI is failing now, but I think exists in #2744 🚀

@zimeg
Copy link
Member Author

zimeg commented Dec 15, 2025

@WilliamBergamin @srtaalej The encouragement to better CI inspires me - thanks for the kind reviews! 👾 ✨

I hope we don't find notifications in channel too often but I will merge this in hopes that we might.

@zimeg zimeg merged commit d7dae86 into main Dec 15, 2025
20 checks passed
@zimeg zimeg deleted the zimeg-ci-sample-regression branch December 15, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code semver:patch tests M-T: Testing work only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants