Skip to content

Commit d6aea71

Browse files
Make it almost work
1 parent 1ba23f0 commit d6aea71

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

tests/scenario_tests/test_web_client_customization.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ def listener(ack, client):
7373

7474
def test_web_client_logger_is_default_app_logger(self):
7575
app = App(token=self.valid_token, signing_secret=self.signing_secret, token_verification_enabled=False)
76-
assert app.client._logger == app.logger # TODO: use client.logger when available
76+
assert app.client.logger == app.logger
7777

7878
def test_web_client_logger_is_app_logger(self):
7979
app = App(
@@ -82,8 +82,8 @@ def test_web_client_logger_is_app_logger(self):
8282
logger=self.test_logger,
8383
token_verification_enabled=False,
8484
)
85-
assert app.client._logger == app.logger # TODO: use client.logger when available
86-
assert app.client._logger == self.test_logger # TODO: use client.logger when available
85+
assert app.client.logger == app.logger
86+
assert app.client.logger == self.test_logger
8787

8888
def test_default_web_client_uses_bolt_framework_logger(self):
8989
app = App(token=self.valid_token, signing_secret=self.signing_secret, token_verification_enabled=False)

tests/scenario_tests_async/test_web_client_customization.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,12 +91,12 @@ async def listener(ack, client):
9191

9292
def test_web_client_logger_is_default_app_logger(self):
9393
app = AsyncApp(token=self.valid_token, signing_secret=self.signing_secret)
94-
assert app.client._logger == app.logger # TODO: use client.logger when available
94+
assert app.client.logger == app.logger
9595

9696
def test_web_client_logger_is_app_logger(self):
9797
app = AsyncApp(token=self.valid_token, signing_secret=self.signing_secret, logger=self.test_logger)
98-
assert app.client._logger == app.logger # TODO: use client.logger when available
99-
assert app.client._logger == self.test_logger # TODO: use client.logger when available
98+
assert app.client.logger == app.logger
99+
assert app.client.logger == self.test_logger
100100

101101
@pytest.mark.asyncio
102102
async def test_default_web_client_uses_bolt_framework_logger(self):

0 commit comments

Comments
 (0)