fix: support deno version 2.x #122
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
===========================================
- Coverage 100.00% 96.83% -3.17%
===========================================
Files 36 39 +3
Lines 1133 1643 +510
Branches 17 25 +8
===========================================
+ Hits 1133 1591 +458
- Misses 0 52 +52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mwbrooks
left a comment
mwbrooks
left a comment
There was a problem hiding this comment.
Hey @WilliamBergamin 👋🏻 I'll take a look at this PR in a bit, but I was curious how updating the test files adds support for Deno 2.x since the distributed module would not include the test files. Or, is this a step forward in adding Deno 2.x support?
| deno-version: | ||
| - v1.x | ||
| - v1.46.2 | ||
| - v2.x |
There was a problem hiding this comment.
praise: Thanks for expanding this out!
.github/workflows/samples.yml
Outdated
| # we test on both most recent stable version of deno (v1.x) as well as | ||
| # the version of deno used by Run on Slack (as noted in https://api.slack.com/slackcli/metadata.json) | ||
| deno-version: [v1.x, v1.45.4] | ||
| deno-version: [v1.x, v1.45.4, 2.x] |
There was a problem hiding this comment.
nit: For consistency with deno.yml, it might be nice to expand this out to a bullet list
There was a problem hiding this comment.
Good point 💯 but I did notice this is and issue for sample CI tests 🤔
There was a problem hiding this comment.
Oh interesting, maybe some of the sample CI test pull the latest and build it? Either way, these are positive changes!
…min/deno-slack-api into ci-deno-version-2.x
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
@WilliamBergamin LGTM!
These are all super nice improvements to tests and testing scripts to keep us confident in this update 🙏 ✨
| persist-credentials: false | ||
|
|
||
| - name: Set imports.deno-slack-api/ to ../deno-slack-api/src/ in import_map.json | ||
| - name: Set imports.deno-slack-api/ to ../deno-slack-api/src/ in imports |
There was a problem hiding this comment.
🔍 The logging in this updated file is so helpful!
https://github.com/slackapi/deno-slack-api/actions/runs/15397083256/job/43320475967#step:5:205
`import file` out content:
...
"deno-slack-api/": "../deno-slack-api/src/",
.github/workflows/samples.yml
Outdated
| deno-version: [v1.x, v1.45.4] | ||
| deno-version: | ||
| - v1.x | ||
| - v1.45.4 |
There was a problem hiding this comment.
This might've been updated recently, but I'm finding 1.46.2 is the current ROSI runtime?
3 participants
Summary
These changes aim to remove the mock_fetch dependency that was cause some issues with Deno 2 in favor of using the standard library stubbing
testing
N/A
Requirements
deno task testafter making the changes.