Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented May 22, 2025

Summary

This PR uses the wonderful zizmor tool to audit our own workflows and pinact for pinned versioning 👾

Reviewers

A similar audit can be performed with the zizmor tool:

$ zizmor .
...
No findings to report. Good job! (4 suppressed)

The suppressed findings are expected permission blocks at the top-level of a workflow, but we set this for each job.

Testing

🔍 CI covers most cases, but on publish we might want to be aware of possible changes to these workflows.

Special notes

🎵 🎺 🦖

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've ran deno task test after making the changes.

@zimeg zimeg self-assigned this May 22, 2025
@zimeg zimeg requested a review from a team as a code owner May 22, 2025 06:37
@zimeg zimeg added the dependencies Pull requests that update a dependency file label May 22, 2025
@codecov
Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f7915fb) to head (1adddc4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #125   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines         1133      1133           
  Branches        17        17           
=========================================
  Hits          1133      1133           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member Author

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 A quick note on confused permissions with the checkout step...

Comment on lines 46 to +49
- name: Setup repo
uses: actions/checkout@v4
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 It's not so clear if permissions.checks:write somehow includes the contents:read scopes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗣️ I was about to loose marbles but this was an expected finding: slackapi/slack-health-score#93

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯

@zimeg
Copy link
Member Author

zimeg commented May 23, 2025

@WilliamBergamin I appreciate the review along this confusion of what permissions are supposed to do. As the ultimate test of CI I will merge this PR now.

@zimeg zimeg merged commit 8bf1dd2 into main May 23, 2025
20 checks passed
@zimeg zimeg deleted the ci-audit branch May 23, 2025 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants