-
Notifications
You must be signed in to change notification settings - Fork 17
ci: pin actions workflow step hashes and use minimum permissions #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 36
Lines 1133 1133
Branches 17 17
=========================================
Hits 1133 1133 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 A quick note on confused permissions with the checkout step...
| - name: Setup repo | ||
| uses: actions/checkout@v4 | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| with: | ||
| persist-credentials: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 It's not so clear if permissions.checks:write somehow includes the contents:read scopes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📚 https://github.com/actions/checkout?tab=readme-ov-file#recommended-permissions
🤖 https://github.com/slackapi/deno-slack-api/actions/runs/15179844434/job/42686910983#step:1:16
GITHUB_TOKEN Permissions
Checks: write
Metadata: read
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗣️ I was about to loose marbles but this was an expected finding: slackapi/slack-health-score#93
WilliamBergamin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 💯
|
@WilliamBergamin I appreciate the review along this confusion of what permissions are supposed to do. As the ultimate test of CI I will merge this PR now. |
Summary
This PR uses the wonderful
zizmortool to audit our own workflows andpinactfor pinned versioning 👾Reviewers
A similar audit can be performed with the
zizmortool:Testing
🔍 CI covers most cases, but on publish we might want to be aware of possible changes to these workflows.
Special notes
🎵 🎺 🦖
Requirements
deno task testafter making the changes.