-
Notifications
You must be signed in to change notification settings - Fork 7
fix: gather app manifest using deno-slack-hooks instead of deno-slack-builder #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for the contribution! Before we can merge this, we need @ledmonster to sign the Salesforce Inc. Contributor License Agreement. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 93.22% 93.41% +0.18%
==========================================
Files 17 17
Lines 620 607 -13
Branches 93 93
==========================================
- Hits 578 567 -11
+ Misses 42 40 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ledmonster LGTM! And thank you for taking the time to send this fix in 📬 ✨
To test this I updated a hooks.json file with the following to match the setups of slackapi/deno-slack-sdk#375 (comment) with this start hook:
{
"hooks": {
"start": "deno run -q --config=deno.jsonc --allow-read --allow-net --allow-run --allow-env --allow-import --allow-sys=osRelease https://raw.githubusercontent.com/slackapi/deno-slack-runtime/9c85a5adcd285aba0d6f2d280894755274055f4e/src/local-run.ts "
}
}Approving this now with a fix to no longer use the "builder" package, but I believe some follow up elsewhere is still needed to avoid import errors. I'm still noticing multiple requests for the same "import" permission when using this command and it's not clear to me why the "--allow-import" flag isn't being used:
$ DENO_TRACE_PERMISSIONS=1 deno run -q --config=deno.jsonc --allow-read --allow-net --allow-run --allow-env --allow-import --allow-sys=osRelease https://raw.githubusercontent.com/slackapi/deno-slack-runtime/9c85a5adcd285aba0d6f2d280894755274055f4e/src/local-run.ts
┏ ⚠️ Deno requests import access to "googleapis.deno.dev:443".
┠─ Requested by `import()` API.
┃ ├─ op_fs_stat_async (ext:core/00_infra.js:249:44)
┃ ├─ Object.stat (ext:deno_fs/30_fs.js:410:21)
┃ ├─ readImportedManifestFile (https://deno.land/x/[email protected]/get_manifest.ts:107:35)
┃ ├─ getManifest (https://deno.land/x/[email protected]/get_manifest.ts:33:28)
┃ ├─ eventLoopTick (ext:core/01_core.js:179:7)
┃ ├─ async runLocally (https://raw.githubusercontent.com/slackapi/deno-slack-runtime/9c85a5adcd285aba0d6f2d280894755274055f4e/src/local-run-function.ts:21:20)
┃ └─ async https://raw.githubusercontent.com/slackapi/deno-slack-runtime/9c85a5adcd285aba0d6f2d280894755274055f4e/src/local-run-function.ts:51:3
Summary
Requirements (place an
xin each[ ])Note