Skip to content

Conversation

@WilliamBergamin
Copy link
Contributor

Summary

This PR configures the project to allow non import prefixes, non import prefixes are critical to this project

Testing

The CI is passing

Special notes

In the future we may want to import dependencies through the deno.jsonc file similar to how our templates do. We will need to investigate if this is a breaking change.

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've ran deno task test after making the changes.

@WilliamBergamin WilliamBergamin self-assigned this Oct 1, 2025
@WilliamBergamin WilliamBergamin requested a review from a team as a code owner October 1, 2025 16:35
@WilliamBergamin WilliamBergamin added the bug Something isn't working label Oct 1, 2025
@zimeg zimeg added the semver:patch requires a patch version number bump label Oct 1, 2025
@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.51%. Comparing base (906ece2) to head (1f17f49).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #482   +/-   ##
=======================================
  Coverage   98.51%   98.51%           
=======================================
  Files          67       67           
  Lines        2567     2567           
  Branches      148      148           
=======================================
  Hits         2529     2529           
  Misses         38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WilliamBergamin LGTM and thanks for these reference 📚 ✨

In the future we may want to import dependencies through the deno.jsonc file similar to how our templates do.

I'm curious about this too, but agree that for now this is a solid change. I like that consolidated imports makes versions easier to grep! 🔍

@WilliamBergamin WilliamBergamin merged commit 4849fb7 into main Oct 1, 2025
20 checks passed
@WilliamBergamin WilliamBergamin deleted the allow-non-import-prefix branch October 1, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working semver:patch requires a patch version number bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants