Consistently use the same OkHttpClient for files.slack.com requests#1428
Merged
seratch merged 1 commit intoslackapi:mainfrom Jan 28, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1428 +/- ##
============================================
+ Coverage 73.21% 73.25% +0.04%
Complexity 4377 4377
============================================
Files 474 474
Lines 14205 14206 +1
Branches 1437 1437
============================================
+ Hits 10400 10407 +7
+ Misses 2958 2951 -7
- Partials 847 848 +1 ☔ View full report in Codecov by Sentry. |
vegeris
approved these changes
Jan 27, 2025
WilliamBergamin
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves a bug where the files.slack.com requests fail when a developer passes OkHttpClient to SlackHttpClient when initializing the API clients to handle specific SSL conditions. This pull request tweak the internal FilesUploadV2Helper class to use the given OkHttpClient rather than creating a new once only using SlackConfig properties.
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.