chore(deps): bump minimum axios version for web-api and webhook to avoid security vuln #2116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2116 +/- ##
=======================================
Coverage 91.66% 91.66%
=======================================
Files 38 38
Lines 10317 10317
Branches 647 647
=======================================
Hits 9457 9457
Misses 848 848
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. |
s-dupuis
approved these changes
Dec 5, 2024
zimeg
approved these changes
Dec 5, 2024
Member
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
LGTM with passing tests!
From other comments, I agree that interactive-message is alright to not update since it's deprecated 🙏
Going to respond on the initial issue with a quick question, but I'm still also wondering about best practices for keeping these packages updated - security updates seem important but having a lower minimum also seems good? 🤔
Feel free to merge and tag when the time is right! 🚀
zimeg
added
semver:patch
security
pkg:web-api
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As described in issue #2115, a major security vuln has been patched in Axios
1.7.8. Updating all packages that use this (web-apiandwebhook) so that minimum version is now1.7.8.Requirements (place an
xin each[ ])