Skip to content

Release: @slack/[email protected], @slack/[email protected], @slack/[email protected] #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hello-ashleyintech merged 2 commits into from
Dec 10, 2024
Merged

Release: @slack/[email protected], @slack/[email protected], @slack/[email protected] #2120

hello-ashleyintech merged 2 commits into from
Dec 10, 2024

Conversation

@hello-ashleyintech
Copy link
Contributor

@hello-ashleyintech hello-ashleyintech commented Dec 9, 2024 •
edited
Loading

Summary

Releases @slack/[email protected], @slack/[email protected], @slack/[email protected] to patch security vulns

Requirements (place an x in each [ ])

@hello-ashleyintech hello-ashleyintech added pkg:rtm-api applies to `@slack/rtm-api` pkg:oauth applies to `@slack/oauth` pkg:socket-mode applies to `@slack/socket-mode` release labels Dec 9, 2024
@hello-ashleyintech hello-ashleyintech requested review from a team and zimeg December 9, 2024 21:04
@codecov
Copy link

codecov bot commented Dec 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.89%. Comparing base (560b5a1) to head (b310cd6).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2120   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files          38       38           
  Lines       10320    10320           
  Branches      649      649           
=======================================
  Hits         9484     9484           
  Misses        824      824           
  Partials       12       12
Flag Coverage Δ
cli-hooks 95.24% <ø> (ø)
cli-test 94.48% <ø> (ø)
oauth 77.39% <ø> (ø)
socket-mode 61.82% <ø> (ø)
web-api 96.88% <ø> (ø)
webhook 96.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

zimeg
zimeg reviewed Dec 9, 2024
View reviewed changes
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick note on the @slack/socket-mode versioning with a recent change 😳

zimeg
zimeg approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 ✨

@hello-ashleyintech
Copy link
Contributor Author

hello-ashleyintech commented Dec 9, 2024

since it's near EOD for me today, will merge this in and release tomorrow and continue towards a new Bolt JS release ✨

@hello-ashleyintech hello-ashleyintech merged commit 3e5e4c6 into main Dec 10, 2024
57 checks passed
@hello-ashleyintech hello-ashleyintech deleted the ah-release-rtm-socket-oauth branch December 10, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zimeg zimeg zimeg approved these changes

Assignees

No one assigned

Labels

pkg:oauth applies to `@slack/oauth` pkg:rtm-api applies to `@slack/rtm-api` pkg:socket-mode applies to `@slack/socket-mode` release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hello-ashleyintech @zimeg