-
Notifications
You must be signed in to change notification settings - Fork 678
feat(types): add table block #2426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2426 +/- ##
==========================================
+ Coverage 92.71% 93.02% +0.30%
==========================================
Files 22 40 +18
Lines 9474 11127 +1653
Branches 625 713 +88
==========================================
+ Hits 8784 10351 +1567
- Misses 678 764 +86
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐦 A note for reviewers after most recent testing!
|
|
||
| /** | ||
| * @description Defines an object containing some text. | ||
| * @see {@link https://docs.slack.dev/reference/block-kit/composition-objects/text-object Text object reference}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 note: This is undocumented as a text object at this time. I've sent a message related to this but believe this is the correct place for the raw_text reference and implementation!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet 💯
|
|
||
| /** | ||
| * @description Defines an object containing some text. | ||
| * @see {@link https://docs.slack.dev/reference/block-kit/composition-objects/text-object Text object reference}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet 💯
| * @description Displays structured information in a table. | ||
| * @see {@link https://docs.slack.dev/reference/block-kit/blocks/table-block Table block reference}. | ||
| */ | ||
| export interface TableBlock extends Block { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Praise!
|
@WilliamBergamin I share excitement for this new block. With expected results appearing on the server side I'll merge this next! 🧱 ✨ |
Summary
This PR adds the
tableblock.🔗 https://docs.slack.dev/reference/block-kit/blocks/table-block
Preview
The following code snippet can be used to post a table:
Notes
Requirements