Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Nov 19, 2025

Summary

This PR changes the codecov step to use "files" for uploading test results. Per the kind migration guides:

🔗 https://github.com/codecov/codecov-action?tab=readme-ov-file#migration-guide

Notes

Fixes warnings of invalid input while perhaps still finding this file otherwise:

Warning: Unexpected input(s) 'file', valid inputs are ['base_sha', 'binary', 'codecov_yml_path', 'commit_parent', 'directory', 'disable_file_fixes', 'disable_search', 'disable_safe_directory', 'disable_telem', 'dry_run', 'env_vars', 'exclude', 'fail_ci_if_error', 'files', 'flags', 'force', 'git_service', 'gcov_args', 'gcov_executable', 'gcov_ignore', 'gcov_include', 'handle_no_reports_found', 'job_code', 'name', 'network_filter', 'network_prefix', 'os', 'override_branch', 'override_build', 'override_build_url', 'override_commit', 'override_pr', 'plugins', 'recurse_submodules', 'report_code', 'report_type', 'root_dir', 'run_command', 'skip_validation', 'slug', 'swift_project', 'token', 'url', 'use_legacy_upload_endpoint', 'use_oidc', 'use_pypi', 'verbose', 'version', 'working-directory']

🔗 https://github.com/slackapi/node-slack-sdk/actions/runs/19472021130/job/55721673209#step:12:1

Requirements

@zimeg zimeg self-assigned this Nov 19, 2025
@zimeg zimeg requested a review from a team as a code owner November 19, 2025 18:13
@zimeg zimeg added semver:patch github_actions Pull requests that update GitHub Actions code labels Nov 19, 2025
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.02%. Comparing base (90ed66e) to head (0d42854).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2439   +/-   ##
=======================================
  Coverage   93.02%   93.02%           
=======================================
  Files          40       40           
  Lines       11127    11127           
  Branches      713      713           
=======================================
  Hits        10351    10351           
  Misses        764      764           
  Partials       12       12           
Flag Coverage Δ
cli-hooks 95.23% <ø> (ø)
cli-test 94.79% <ø> (ø)
oauth 77.39% <ø> (ø)
socket-mode 61.87% <ø> (ø)
web-api 98.08% <ø> (ø)
webhook 96.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 💯

@zimeg
Copy link
Member Author

zimeg commented Nov 19, 2025

@WilliamBergamin These warning logs were so interesting to find! Let's continue the quest to code health! 🏥 ✨

@zimeg zimeg merged commit 8da8e09 into main Nov 19, 2025
57 checks passed
@zimeg zimeg deleted the zimeg-ci-codecov-files branch November 19, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code semver:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants