Skip to content

Conversation

@misscoded
Copy link
Contributor

Summary

Resolves #2427 by adding missing huddle_state_call_id. See payload in docs for verification of this property's existence.

Per original issue:

You will receive a payload typed as UserHuddleChangedEvent. If payload.user.profile.huddle_state has the value in_a_huddle, then the payload you will receive contains payload.user.profile.huddle_state_call_id, which is not listed within the type UserHuddleChangedEvent.

Technically this property only appears as a conditional state based upon another property, but as we're not getting that granular with any other optional property, just leaving it as a simple optional here.

Requirements (place an x in each [ ])

@misscoded misscoded requested a review from a team as a code owner December 1, 2025 23:47
@misscoded misscoded added enhancement M-T: A feature request for new functionality pkg:types applies to `@slack/types` labels Dec 1, 2025
@misscoded misscoded requested review from mwbrooks and zimeg December 1, 2025 23:47
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.09%. Comparing base (9a0c4c4) to head (548676c).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2448   +/-   ##
=======================================
  Coverage   93.09%   93.09%           
=======================================
  Files          40       40           
  Lines       11240    11240           
  Branches      713      713           
=======================================
  Hits        10464    10464           
  Misses        764      764           
  Partials       12       12           
Flag Coverage Δ
cli-hooks 95.23% <ø> (ø)
cli-test 94.79% <ø> (ø)
oauth 77.39% <ø> (ø)
socket-mode 61.87% <ø> (ø)
web-api 98.11% <ø> (ø)
webhook 96.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zimeg zimeg changed the title Add huddle_state_call_id to UserHuddleChangedEvent feat(types): add huddle_state_call_id to UserHuddleChangedEvent Dec 3, 2025
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@misscoded LGTM! I was curious about these huddle prefixes and it's so interesting to find:

R017QJ4PEN7

@zimeg zimeg added this to the [email protected] milestone Dec 3, 2025
@misscoded misscoded merged commit 8ec9015 into main Dec 4, 2025
57 checks passed
@misscoded misscoded deleted the 2427-update-user-huddle-changed branch December 4, 2025 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality pkg:types applies to `@slack/types` semver:minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

huddle_state_call_id is missing within the user profile type

3 participants