Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented May 20, 2025

Summary

This PR uses the wonderful zizmor tool to audit our own workflows and pinact for pinned versioning 👾

Testing

🔍 Let's let CI do this for us!

Reviewers

A similar audit can be performed with the zizmor tool:

$ zizmor .
...
No findings to report. Good job! (1 ignored, 4 suppressed)

The suppressed findings are expected permission blocks at the top-level of a workflow, but we set this for each job.

Special notes

💌 Thanks for reviewing these changes!

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_and_run_tests.sh after making the changes.

@zimeg zimeg self-assigned this May 20, 2025
@zimeg zimeg added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels May 20, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.68%. Comparing base (04f3c33) to head (acd6f53).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #58   +/-   ##
=======================================
  Coverage   94.68%   94.68%           
=======================================
  Files          11       11           
  Lines         207      207           
=======================================
  Hits          196      196           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@zimeg
Copy link
Member Author

zimeg commented May 21, 2025

@WilliamBergamin The end is near! For at least this set of CI permission updates. I so hope at least 😉

Merging this brings us one step closer to whatever that end might be so I will do that 🚢 💨

@zimeg zimeg merged commit 6c4d1ef into main May 21, 2025
13 checks passed
@zimeg zimeg deleted the ci-audit branch May 21, 2025 01:29
@zimeg zimeg added this to the 0.1.0 milestone Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants