-
Notifications
You must be signed in to change notification settings - Fork 1
chore: support python 3.13 #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
=======================================
Coverage 94.68% 94.68%
=======================================
Files 11 11
Lines 207 207
=======================================
Hits 196 196
Misses 11 11 β View full report in Codecov by Sentry. π New features to boost your workflow:
|
mwbrooks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
β Thanks a lot @zimeg!
β Is there any automation that we can use to keep this up-to-date?
|
@mwbrooks I do hope so, but I'm not aware of such at this time πΎ Poking into this topic, I'm not sure if these new versions bring breaking changes alongside deprecations of the last version though:
π https://docs.python.org/3/faq/general.html#how-does-the-python-version-numbering-scheme-work That might sometimes require us to make changes, but I'm optimistic we can soon remain with the current supported versions overall. I agree that if automations do appear it would be nice to use these! |
ewanek1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! βΊ βΊ
It seems like some developers have run into similar tedious tasks of manually updating version numbers and created tools to automate it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this π―
@ewanek1 This is so interesting to me! The author seems to be using a standalone script to make these updates and I'm now both curious and optimistic that we might later adapt something similar to these codebases. I find custom workflows can be so useful, but can also be time consuming to set up. The I'll merge this as is but am keeping watch for these improvements since I believe ongoing maintenance should be little effort. Also, thank you for sharing this! @mwbrooks @ewanek1 @WilliamBergamin I appreciate the kind reviews. I will merge this and am also interested in a release soon after, but will save that discussion for another PR! π’ |
Summary
This PR adds support for Python 3.13 π β¨
Reference
Requirements
./scripts/install_and_run_tests.shafter making the changes.