Skip to content

fix: 'ClientConnection' object has no attribute 'closed' #1613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WilliamBergamin merged 6 commits into from
Dec 13, 2024

Fix an issue with old version of websockets

4f3c4c7
Select commit
Loading
Failed to load commit list.
Merged

fix: 'ClientConnection' object has no attribute 'closed' #1613

Fix an issue with old version of websockets
4f3c4c7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 12, 2024 in 0s

84.89% (-0.04%) compared to a7223d9

View this Pull Request on Codecov

84.89% (-0.04%) compared to a7223d9

Details

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.89%. Comparing base (a7223d9) to head (4f3c4c7).

Files with missing lines Patch % Lines
slack_sdk/socket_mode/websockets/__init__.py 64.70% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1613      +/-   ##
==========================================
- Coverage   84.93%   84.89%   -0.04%     
==========================================
  Files         113      113              
  Lines       12630    12639       +9     
==========================================
+ Hits        10727    10730       +3     
- Misses       1903     1909       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov