Skip to content

health: move to mypy #1620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WilliamBergamin merged 14 commits into from
Dec 29, 2024

Fix edge case

9ba8e07
Select commit
Loading
Failed to load commit list.
Merged

health: move to mypy #1620

Fix edge case
9ba8e07
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 20, 2024 in 0s

85.06% (+0.03%) compared to 241db14

View this Pull Request on Codecov

85.06% (+0.03%) compared to 241db14

Details

Codecov Report

Attention: Patch coverage is 81.87809% with 110 lines in your changes missing coverage. Please review.

Project coverage is 85.06%. Comparing base (241db14) to head (9ba8e07).

Files with missing lines Patch % Lines
slack_sdk/web/async_client.py 80.55% 14 Missing ⚠️
slack_sdk/web/client.py 80.55% 14 Missing ⚠️
slack_sdk/web/legacy_client.py 80.55% 14 Missing ⚠️
slack_sdk/socket_mode/builtin/internals.py 47.36% 10 Missing ⚠️
...sdk/oauth/installation_store/amazon_s3/__init__.py 36.36% 7 Missing ⚠️
slack_sdk/audit_logs/v1/logs.py 33.33% 4 Missing ⚠️
slack_sdk/web/internal_utils.py 20.00% 4 Missing ⚠️
slack_sdk/audit_logs/v1/client.py 25.00% 3 Missing ⚠️
...k_sdk/oauth/installation_store/sqlite3/__init__.py 40.00% 3 Missing ⚠️
slack_sdk/socket_mode/aiohttp/__init__.py 66.66% 3 Missing ⚠️
... and 24 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1620      +/-   ##
==========================================
+ Coverage   85.03%   85.06%   +0.03%     
==========================================
  Files         113      113              
  Lines       12661    12658       -3     
==========================================
+ Hits        10766    10768       +2     
+ Misses       1895     1890       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov