-
Notifications
You must be signed in to change notification settings - Fork 850
chore: remove 3.6 references #1735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
07da9c1
73bffb0
863c41a
91fa478
26ba131
25ba174
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -10,7 +10,7 @@ Refer to the [migration guide](/tools/python-slack-sdk/v3-migration) to learn ho | |||||
|
|
||||||
| Slack APIs allow anyone to build full featured integrations that extend and expand the capabilities of your Slack workspace. These APIs allow you to build applications that interact with Slack just like the people on your team. They can post messages, respond to events that happen, and build complex UIs for getting work done. | ||||||
|
|
||||||
| To make it easier for Python programmers to build Slack applications, we've provided this open source SDK that will help you get started building Python apps as quickly as possible. The current version is built for Python 3.6 and higher — if you need to target Python 2.x, you might consider using v1 of the SDK. | ||||||
| To make it easier for Python programmers to build Slack applications, we've provided this open source SDK that will help you get started building Python apps as quickly as possible. The current version is built for Python 3.7 and higher — if you need to target Python 2.x, you might consider using v1 of the SDK. | ||||||
|
||||||
| To make it easier for Python programmers to build Slack applications, we've provided this open source SDK that will help you get started building Python apps as quickly as possible. The current version is built for Python 3.7 and higher — if you need to target Python 2.x, you might consider using v1 of the SDK. | |
| To make it easier for Python programmers to build Slack applications, we've provided this open source SDK that will help you get started building Python apps as quickly as possible. The current version is built for Python 3.7 and higher. |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -69,7 +69,7 @@ If you don't wish to upgrade yet, be sure to pin your module for the Python `sla | |||||
|
|
||||||
| ### Minimum Python versions {#minimum-versions} | ||||||
|
|
||||||
| `slackclient` v2.x requires Python 3.6 (or higher). Support for Python 2.7 is maintained in the existing `slackclient` v1.x. | ||||||
| `slackclient` v2.x requires Python 3.7 (or higher). Support for Python 2.7 is maintained in the existing `slackclient` v1.x. | ||||||
|
||||||
| `slackclient` v2.x requires Python 3.7 (or higher). Support for Python 2.7 is maintained in the existing `slackclient` v1.x. | |
| `slackclient` v2.x requires Python 3.7 (or higher). |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,7 +43,7 @@ async def test_issue_480_processes_async(self): | |
| after = len(multiprocessing.active_children()) | ||
| self.assertEqual(0, after - before) | ||
|
|
||
| # fails with Python 3.6 | ||
| # fails with Python 3.6 (no longer supported) | ||
|
||
| def test_issue_480_threads(self): | ||
| client = self.sync_client | ||
| before = threading.active_count() | ||
|
|
@@ -53,7 +53,7 @@ def test_issue_480_threads(self): | |
| after = threading.active_count() | ||
| self.assertEqual(0, after - before) | ||
|
|
||
| # fails with Python 3.6 | ||
| # fails with Python 3.6 (no longer supported) | ||
|
||
| @async_test | ||
| async def test_issue_480_threads_async(self): | ||
| client = self.async_client | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ name = "slack_sdk" | |
| dynamic = ["version", "readme", "authors", "optional-dependencies"] | ||
| description = "The Slack API Platform SDK for Python" | ||
| license = { text = "MIT" } | ||
| requires-python = ">=3.6" | ||
| requires-python = ">=3.7" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Praise 🙏 |
||
| keywords = [ | ||
| "slack", | ||
| "slack-api", | ||
|
|
@@ -27,7 +27,6 @@ classifiers = [ | |
| "License :: OSI Approved :: MIT License", | ||
| "Programming Language :: Python", | ||
| "Programming Language :: Python :: 3 :: Only", | ||
| "Programming Language :: Python :: 3.6", | ||
| "Programming Language :: Python :: 3.7", | ||
| "Programming Language :: Python :: 3.8", | ||
| "Programming Language :: Python :: 3.9", | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -4,12 +4,12 @@ pytest>=7.0.1,<9 | |||||||
| pytest-asyncio<2 # for async | ||||||||
| pytest-cov>=2,<7 | ||||||||
| # while flake8 5.x have issues with Python 3.12, flake8 6.x requires Python >= 3.8.1, | ||||||||
| # so 5.x should be kept in order to stay compatible with Python 3.6/3.7 | ||||||||
| # so 5.x should be kept in order to stay compatible with Python 3.7/3.8 | ||||||||
| flake8>=5.0.4,<8 | ||||||||
| # Don't change this version without running CI builds; | ||||||||
| # The latest version may not be available for older Python runtime | ||||||||
| black>=22.8.0; python_version=="3.6" | ||||||||
| black==22.10.0; python_version>"3.6" | ||||||||
| black>=22.8.0; python_version=="3.7" | ||||||||
| black==22.10.0; python_version>="3.8" | ||||||||
|
||||||||
| black>=22.8.0; python_version=="3.7" | |
| black==22.10.0; python_version>="3.8" | |
| black==22.10.0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes I agree. Black v22.10.0 supports python 3.7 so the split requirement doesn’t seem to be needed anymore!
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -56,7 +56,7 @@ def _get_headers( | |||||
| e.g. { | ||||||
| 'Content-Type': 'application/json;charset=utf-8', | ||||||
| 'Authorization': 'Bearer xoxb-1234-1243', | ||||||
| 'User-Agent': 'Python/3.6.8 slack/2.1.0 Darwin/17.7.0' | ||||||
| 'User-Agent': 'Python/3.7.0 slack/2.1.0 Darwin/17.7.0' | ||||||
|
||||||
| 'User-Agent': 'Python/3.7.0 slack/2.1.0 Darwin/17.7.0' | |
| 'User-Agent': 'Python/3.7.17 slack/2.1.0 Darwin/17.7.0' |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,7 +44,7 @@ def get_user_agent(prefix: Optional[str] = None, suffix: Optional[str] = None): | |
|
|
||
| Returns: | ||
| The user agent string. | ||
| e.g. 'Python/3.6.7 slackclient/2.0.0 Darwin/17.7.0' | ||
| e.g. 'Python/3.7.0 slackclient/2.0.0 Darwin/17.7.0' | ||
|
||
| """ | ||
| # __name__ returns all classes, we only want the client | ||
| client = "{0}/{1}".format("slackclient", version.__version__) | ||
|
|
@@ -91,7 +91,7 @@ def _get_headers( | |
| e.g. { | ||
| 'Content-Type': 'application/json;charset=utf-8', | ||
| 'Authorization': 'Bearer xoxb-1234-1243', | ||
| 'User-Agent': 'Python/3.6.8 slack/2.1.0 Darwin/17.7.0' | ||
| 'User-Agent': 'Python/3.7.0 slack/2.1.0 Darwin/17.7.0' | ||
|
||
| } | ||
| """ | ||
| final_headers = { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,7 @@ def print(message: str): | |
|
|
||
| validate_aiohttp_version("2.1.3", print) | ||
| self.assertEqual(state["counter"], 1) | ||
| validate_aiohttp_version("3.6.3", print) | ||
| validate_aiohttp_version("3.7.0", print) | ||
|
||
| self.assertEqual(state["counter"], 2) | ||
| validate_aiohttp_version("3.7.0", print) | ||
| self.assertEqual(state["counter"], 3) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,14 +21,14 @@ As you complete each task you'll see the message update with a green checkmark. | |
| 1. A Slack team. | ||
| Before anything else you'll need a Slack team. You can [Sign into an existing Slack workspace](https://get.slack.help/hc/en-us/articles/212681477-Sign-in-to-Slack) or you can [create a new Slack workspace](https://get.slack.help/hc/en-us/articles/206845317-Create-a-Slack-workspace) to test your app first. | ||
|
|
||
| 2. A terminal with Python 3.6+ installed. | ||
| 2. A terminal with Python 3.7+ installed. | ||
| Check your installation by running the following command in your terminal: | ||
| ``` | ||
| $ python3 --version | ||
| -> Python 3.6.7 | ||
| -> Python 3.7.0 | ||
|
||
| ``` | ||
|
|
||
| You'll need to install Python 3.6 if you receive the following error: | ||
| You'll need to install Python 3.7 if you receive the following error: | ||
| ``` | ||
| -> bash: python3: command not found | ||
| ``` | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also remove the python 2 sentence 😅 the slackClient - v1.x is deprecated