build: package for apple intel and apple silicon machines alongside universal binaries as fallback #101
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,11 +41,23 @@ builds: | |
| - darwin | ||
| goarch: | ||
| - amd64 | ||
| - arm64 | ||
| hooks: | ||
| post: |- | ||
| sh -c ' | ||
| zip ./dist/slack_cli_{{ .Env.BUILD_VERSION }}_macOS_{{ .Arch }}.zip ./dist/slack-macos_{{ .Target }}/bin/slack -j | ||
|
Member
Author
There was a problem hiding this comment. 📝 Here we
|
||
| ' | ||
|
|
||
| universal_binaries: | ||
| - id: slack-macos | ||
| name_template: bin/slack | ||
| replace: false | ||
| hooks: | ||
| post: |- | ||
| sh -c ' | ||
| zip ./dist/slack_cli_{{.Env.BUILD_VERSION}}_macOS_64-bit.zip ./dist/slack-macos_darwin_all/bin/slack -j | ||
| ' | ||
|
Comment on lines
+51
to
+59
Member
Author
There was a problem hiding this comment. 📚 https://goreleaser.com/customization/universalbinaries/ The
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment. I must give so much credit to the great folks at @goreleaser 🙏 ✨ |
||
|
|
||
| archives: | ||
| - id: slack | ||
| ids: | ||
|
|
@@ -60,11 +72,11 @@ archives: | |
| name_template: >- | ||
| {{- .ProjectName }}_ | ||
| {{- .Env.BUILD_VERSION }}_ | ||
| {{- if eq .Os "darwin" -}} | ||
| macOS_{{ if eq .Arch "all" }}64-bit{{ else }}{{ .Arch }}{{ end }} | ||
| {{- else -}} | ||
| {{ .Os }}_{{ if eq .Arch "amd64" }}64-bit{{ else }}{{ .Arch }}{{ end }} | ||
| {{- end }} | ||
|
|
||
| snapshot: | ||
| version_template: "{{ .Env.BUILD_VERSION }}" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| // Copyright 2022-2025 Salesforce, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package update | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func Test_CLI_getUpdateFileName(t *testing.T) { | ||
| tests := map[string]struct { | ||
| version string | ||
| operatingSystem string | ||
| architecture string | ||
| expectedFilename string | ||
| expectedErrorF string | ||
| }{ | ||
| "darwin production x86_64": { | ||
| version: "3.4.5", | ||
| operatingSystem: "darwin", | ||
| architecture: "amd64", | ||
| expectedFilename: "slack_cli_3.4.5_macOS_amd64.zip", | ||
| }, | ||
| "darwin development x86_64": { | ||
| version: "3.4.5-6-badaabad", | ||
| operatingSystem: "darwin", | ||
| architecture: "amd64", | ||
| expectedFilename: "slack_cli_3.4.5-6-badaabad_macOS_amd64.zip", | ||
| }, | ||
| "darwin production aarch64": { | ||
| version: "3.4.5", | ||
| operatingSystem: "darwin", | ||
| architecture: "arm64", | ||
| expectedFilename: "slack_cli_3.4.5_macOS_arm64.zip", | ||
| }, | ||
| "darwin development aarch64": { | ||
| version: "3.4.5-6-badaabad", | ||
| operatingSystem: "darwin", | ||
| architecture: "arm64", | ||
| expectedFilename: "slack_cli_3.4.5-6-badaabad_macOS_arm64.zip", | ||
| }, | ||
| "darwin production universal": { | ||
| version: "3.4.5", | ||
| operatingSystem: "darwin", | ||
| architecture: "fallback", | ||
| expectedFilename: "slack_cli_3.4.5_macOS_64-bit.zip", | ||
| }, | ||
| "darwin development universal": { | ||
| version: "3.4.5-6-badaabad", | ||
| operatingSystem: "darwin", | ||
| architecture: "fallback", | ||
| expectedFilename: "slack_cli_3.4.5-6-badaabad_macOS_64-bit.zip", | ||
| }, | ||
| "linux production x86_64": { | ||
| version: "3.4.5", | ||
| operatingSystem: "linux", | ||
| architecture: "amd64", | ||
| expectedFilename: "slack_cli_3.4.5_linux_64-bit.tar.gz", | ||
| }, | ||
| "linux development x86_64": { | ||
| version: "3.4.5-6-badaabad", | ||
| operatingSystem: "linux", | ||
| architecture: "amd64", | ||
| expectedFilename: "slack_cli_3.4.5-6-badaabad_linux_64-bit.tar.gz", | ||
| }, | ||
| "windows production x86_64": { | ||
| version: "3.4.5", | ||
| operatingSystem: "windows", | ||
| architecture: "amd64", | ||
| expectedFilename: "slack_cli_3.4.5_windows_64-bit.zip", | ||
| }, | ||
| "windows development x86_64": { | ||
| version: "3.4.5-6-badaabad", | ||
| operatingSystem: "windows", | ||
| architecture: "amd64", | ||
| expectedFilename: "slack_cli_3.4.5-6-badaabad_windows_64-bit.zip", | ||
| }, | ||
| "unknown production errors": { | ||
| version: "3.4.5", | ||
| operatingSystem: "dragonfly", | ||
| architecture: "amd64", | ||
| expectedErrorF: "auto-updating for the operating system (dragonfly) is unsupported", | ||
| }, | ||
| } | ||
| for name, tt := range tests { | ||
| t.Run(name, func(t *testing.T) { | ||
| filename, err := getUpdateFileName(tt.version, tt.operatingSystem, tt.architecture) | ||
| if tt.expectedErrorF != "" { | ||
| require.Error(t, err) | ||
| require.ErrorContains(t, err, tt.expectedErrorF) | ||
| } else { | ||
| require.NoError(t, err) | ||
| require.Equal(t, tt.expectedFilename, filename) | ||
| } | ||
| }) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋🏻 Bye!