Skip to content

Conversation

@mwbrooks
Copy link
Member

Summary

This pull request adds test coverage to slackdeps.NewFs(). Easy review! 🕺🏻 💃🏻

Requirements

@mwbrooks mwbrooks added this to the Next Release milestone May 21, 2025
@mwbrooks mwbrooks self-assigned this May 21, 2025
@mwbrooks mwbrooks added code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment labels May 21, 2025
@codecov
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.33%. Comparing base (775c7ef) to head (6915315).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   63.29%   63.33%   +0.03%     
==========================================
  Files         211      211              
  Lines       22282    22282              
==========================================
+ Hits        14104    14112       +8     
+ Misses       7087     7083       -4     
+ Partials     1091     1087       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mwbrooks mwbrooks marked this pull request as ready for review May 21, 2025 16:44
@mwbrooks mwbrooks requested a review from a team as a code owner May 21, 2025 16:44
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwbrooks 📝 🔬 ✨ Wow!

This is a nice test to have for all future enhancements and changes around file handling - thank you for making this file 🙏 ✨

@mwbrooks
Copy link
Member Author

Thanks @zimeg! It feels strange putting up such a small PR with minimal test coverage impact, but having the file exists allows future tests to be added easier. 🦠 🔬 🧑‍🔬

@mwbrooks mwbrooks merged commit 8698f51 into main May 21, 2025
6 checks passed
@mwbrooks mwbrooks deleted the mwbrooks-test-fs branch May 21, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants