refactor: enable linter rule ST1023 for 'Redundant type in variable declaration' #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwbrooks
added
code health
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
+ Coverage 63.30% 63.32% +0.02%
==========================================
Files 211 211
Lines 22282 22282
==========================================
+ Hits 14105 14110 +5
+ Misses 7088 7085 -3
+ Partials 1089 1087 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
lol thanks @zimeg! Ultrabasic PR, but it's nice to have a history of enabling the rule 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request enables the linter staticcheck rule ST1023: 'Redundant type in variable declaration'.
Nothing to see here. Originally, commit 6811517 removed the redundant types. But since putting the PR together, we actually removed this in a different linter update!
Requirements