feat: include errors from the sdk in outputs of erroring hooks

[zimeg]

Changelog

Outputs from erroring hook scripts - such found when gathering an odd app manifest - are no longer hidden in verbose outputs and are instead shown with invocation errors.

Summary

This PR includes the SDK hook script error in CLI error outputs to improve the debug experience, as @WilliamBergamin noted 🙏 ✨

Preview

Before changes

before.mov

After changes

after.mov

Reviewers

The following commands can be used to check these erroring outputs:

$ slack create asdf -t slack-samples/bolt-js-starter-template
$ cd asdf
$ slack manifest  # No errors we hope
$ echo "{" >> manifest.json"
$ slack manifest  # Errors with detail
$ vim .slack/hooks.json
{
  "hooks": {
    "get-hooks": "npx -q --no-install -p @slack/cli-hooks slack-cli-get-hooks"
  },
  "config": {
    "protocol-version": ["default"]
  }
}
$ slack manifest  # Default protocol also has details

Notes

• Surfacing errors parsing .slack/hooks.json is left for a followup PR, but these are shown in verbose outputs for now 🙏
• Exit codes might not match what's returned in hook scripts and updates are left for a follow up PR also!

Requirements

• I've read and understood the Contributing Guidelines and have done my best effort to follow them.
• I've read and agree to the Code of Conduct.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.49%. Comparing base (d294a85) to head (e6d159e).
Report is 14 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   63.47%   63.49%   +0.02%     
==========================================
  Files         212      212              
  Lines       22331    22341      +10     
==========================================
+ Hits        14174    14185      +11     
+ Misses       7067     7065       -2     
- Partials     1090     1091       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[WilliamBergamin]

Nice 💯

[zimeg]

📝 A recent change after additional testing of erroneous cases for the wonderful reviewers more!

[zimeg]

📣 This guards against duplicating outputs that are streamed for certain hooks, such as local run for ROSI apps or a deploy hook script.

Before changes:

---

After changes:

[mwbrooks]

✅ Great improvement to debugging errors in SDK hooks! 🎉 And I'm surprised at how small the change was to do it.

[zimeg]

@WilliamBergamin @mwbrooks Thank y'all both for suggesting these changes and iterations needed for improved error handling with hooks - this is much more clear than parsing debug logs IMO and I hope makes finding fixes quick.

I'll merge this now so we can test this in development! 👾 ✨