ci: exit with with error code if the build archive script fails

[zimeg]

Summary

This PR adds the set -e bash command to "exit immediately if a pipeline ... returns a non-zero status".

Fixes an issue where uploading missing files as an asset to a release was attempted, but nothing existed and blank bytes were uploaded instead! Erroring seems best in these cases.

Notes

The set -o option is included to for a bit more insight into the options being used 🤖 ✨

Requirements

• I've read and understood the Contributing Guidelines and have done my best effort to follow them.
• I've read and agree to the Code of Conduct.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.78%. Comparing base (ae5aa34) to head (050f8c1).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   62.79%   62.78%   -0.02%     
==========================================
  Files         210      210              
  Lines       22053    22053              
==========================================
- Hits        13849    13845       -4     
+ Misses       7128     7127       -1     
- Partials     1076     1081       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[mwbrooks]

✅ LGTM! This is a great check that will help prevent corrupt builds from passing 🔒

[zimeg]

@mwbrooks Thanks for confirming the suspicions and hopes of this PR 🙏 ✨

And also for using a more correct label! I think bug might be best for problems facing developers and since this is an internal fix - ci nonetheless - I think codehealth is a great choice for this 🏥 ✨

[mwbrooks]

And also for using a more correct label! I think bug might be best for problems facing developers and since this is an internal fix - ci nonetheless - I think codehealth is a great choice for this 🏥 ✨

I was actually typing up a similar suggestion. bug is a correct label, but it makes us think about a user-facing bug. We may want to have a build or ci/cd or devops or something label!

[zimeg]

@mwbrooks I'm so open to the build label! 🏷️

That's a nice distinction from "test" and "refactor" changes covered with codehealth and "build" covers all things related to turning code into compilation 🤖

[zimeg]

@mwbrooks I'm quite glad we caught some label strangeness in this PR!

I've made updates to use build where dependencies or CI is changed and I'm hoping we can now use the "code health" label for tests and refactors instead 🎉

Thanks for a great review as always. I'll merge this now for more sureness in these steps for our next release.