Skip to content

Conversation

@mwbrooks
Copy link
Member

@mwbrooks mwbrooks commented Apr 4, 2025

Summary

This pull request updates the MAINTAINERS_GUIDE.md with our latest labels and descriptions. I also organized the list of labels alphabetically, so it's easier to compare with the GitHub Labels.

Requirements

@mwbrooks mwbrooks added docs M-T: Documentation work only semver:patch Use on pull requests to describe the release version increment labels Apr 4, 2025
@mwbrooks mwbrooks added this to the Next Release milestone Apr 4, 2025
@mwbrooks mwbrooks self-assigned this Apr 4, 2025
@mwbrooks mwbrooks changed the title docs: update maintainer's guide with up-to-date labels docs: update maintainer's guide with the latest labels Apr 4, 2025
@codecov
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.82%. Comparing base (811c6a0) to head (09bb229).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage   62.82%   62.82%           
=======================================
  Files         210      210           
  Lines       22053    22053           
=======================================
  Hits        13854    13854           
  Misses       7122     7122           
  Partials     1077     1077           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


- `bug`: A confirmed bug report. A bug is considered confirmed when reproduction
steps have been documented and the issue has been reproduced.
- `build`: A change to the build, compile, or CI/CD pipeline.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the build label

- `build`: A change to the build, compile, or CI/CD pipeline.
- `changelog`: An issue or pull request that should be mentioned in the public
release notes or CHANGELOG.
- `code health`: An issue or pull request that is focused on internal refactors
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a space in code health

Comment on lines +687 to +689
- `semver:major`: A change that requires a semver major release.
- `semver:minor`: A change that requires a semver minor release.
- `semver:patch`: A change that requires a semver patch release.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the semver:* labels

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so pleased that these are alphabetical! 🙏

Comment on lines +690 to +691
- `server side issue`: An issue that exists on the Slack Platform, Slack API,
or other remote endpoint.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched server-side-issue for server side issue and added a period to the sentence

Comment on lines +672 to 686
- `discussion`: An issue that is purely meant to hold a discussion. Typically
the maintainers are looking for feedback in this issues.
- `documentation`: An issue that is purely about documentation work.
- `duplicate`: An issue that is functionally the same as another issue. Apply
this only if you've linked the other issue by number.
- `enhancement`: A feature request for something this package might not already
do.
- `documentation`: An issue that is purely about documentation work.
- `tests`: An issue that is purely about testing work.
- `experiment`: A change that is accessed behind the --experiment flag or toggle
- `good first issue`: An issue that has a well-defined relatively-small scope,
with clear expectations. It helps when the testing approach is also known.
- `needs info`: An issue that may have claimed to be a bug but was not
reproducible, or was otherwise missing some information.
- `discussion`: An issue that is purely meant to hold a discussion. Typically
the maintainers are looking for feedback in this issues.
- `question`: An issue that is like a support request because the user's usage
was not correct.
- `security`: An issue that has special consideration for security reasons.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are unchanged, but ordered alphabetically.

@mwbrooks mwbrooks marked this pull request as ready for review April 4, 2025 20:02
@mwbrooks mwbrooks requested a review from a team as a code owner April 4, 2025 20:02
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwbrooks This is wonderful organization and gives at least me so much peace of mind.

Thanks so much for keeping this up to date 🧰 ✨

Comment on lines +687 to +689
- `semver:major`: A change that requires a semver major release.
- `semver:minor`: A change that requires a semver minor release.
- `semver:patch`: A change that requires a semver patch release.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so pleased that these are alphabetical! 🙏

3. **Labels**:
1. One of the following main labels to describe the type of pull request:
- Main labels always have a description that starts with `M-T:`
- Example: `enhancement`, `bug`, `discussion`, `documentation`, `tests`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️‍🗨️ Great catch!

@mwbrooks mwbrooks merged commit a965505 into main Apr 4, 2025
6 checks passed
@mwbrooks mwbrooks deleted the mbrooks-maintainers-guide-labels branch April 4, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs M-T: Documentation work only semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants