-
Notifications
You must be signed in to change notification settings - Fork 24
docs: update maintainer's guide with the latest labels #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
=======================================
Coverage 62.82% 62.82%
=======================================
Files 210 210
Lines 22053 22053
=======================================
Hits 13854 13854
Misses 7122 7122
Partials 1077 1077 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| - `bug`: A confirmed bug report. A bug is considered confirmed when reproduction | ||
| steps have been documented and the issue has been reproduced. | ||
| - `build`: A change to the build, compile, or CI/CD pipeline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the build label
| - `build`: A change to the build, compile, or CI/CD pipeline. | ||
| - `changelog`: An issue or pull request that should be mentioned in the public | ||
| release notes or CHANGELOG. | ||
| - `code health`: An issue or pull request that is focused on internal refactors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a space in code health
| - `semver:major`: A change that requires a semver major release. | ||
| - `semver:minor`: A change that requires a semver minor release. | ||
| - `semver:patch`: A change that requires a semver patch release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the semver:* labels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm so pleased that these are alphabetical! 🙏
| - `server side issue`: An issue that exists on the Slack Platform, Slack API, | ||
| or other remote endpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switched server-side-issue for server side issue and added a period to the sentence
| - `discussion`: An issue that is purely meant to hold a discussion. Typically | ||
| the maintainers are looking for feedback in this issues. | ||
| - `documentation`: An issue that is purely about documentation work. | ||
| - `duplicate`: An issue that is functionally the same as another issue. Apply | ||
| this only if you've linked the other issue by number. | ||
| - `enhancement`: A feature request for something this package might not already | ||
| do. | ||
| - `documentation`: An issue that is purely about documentation work. | ||
| - `tests`: An issue that is purely about testing work. | ||
| - `experiment`: A change that is accessed behind the --experiment flag or toggle | ||
| - `good first issue`: An issue that has a well-defined relatively-small scope, | ||
| with clear expectations. It helps when the testing approach is also known. | ||
| - `needs info`: An issue that may have claimed to be a bug but was not | ||
| reproducible, or was otherwise missing some information. | ||
| - `discussion`: An issue that is purely meant to hold a discussion. Typically | ||
| the maintainers are looking for feedback in this issues. | ||
| - `question`: An issue that is like a support request because the user's usage | ||
| was not correct. | ||
| - `security`: An issue that has special consideration for security reasons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are unchanged, but ordered alphabetically.
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mwbrooks This is wonderful organization and gives at least me so much peace of mind.
Thanks so much for keeping this up to date 🧰 ✨
| - `semver:major`: A change that requires a semver major release. | ||
| - `semver:minor`: A change that requires a semver minor release. | ||
| - `semver:patch`: A change that requires a semver patch release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm so pleased that these are alphabetical! 🙏
| 3. **Labels**: | ||
| 1. One of the following main labels to describe the type of pull request: | ||
| - Main labels always have a description that starts with `M-T:` | ||
| - Example: `enhancement`, `bug`, `discussion`, `documentation`, `tests` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👁️🗨️ Great catch!
Summary
This pull request updates the
MAINTAINERS_GUIDE.mdwith our latest labels and descriptions. I also organized the list of labels alphabetically, so it's easier to compare with the GitHub Labels.Requirements