Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Jun 6, 2025

Summary

This PR moves configurations for the CircleCI runner into the .circleci path to avoid confusing source code and build logic 🤖

Notes

  • A corresponding PR will soon exist for the runner to find these new paths!

Requirements

@zimeg zimeg added this to the Next Release milestone Jun 6, 2025
@zimeg zimeg requested a review from cchensh June 6, 2025 22:13
@zimeg zimeg self-assigned this Jun 6, 2025
@zimeg zimeg requested a review from a team as a code owner June 6, 2025 22:13
@zimeg zimeg added code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment build M-T: Changes to compilation and CI processes labels Jun 6, 2025
@codecov
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.46%. Comparing base (d1372cc) to head (0650dfb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #120   +/-   ##
=======================================
  Coverage   63.45%   63.46%           
=======================================
  Files         212      212           
  Lines       22341    22341           
=======================================
+ Hits        14176    14178    +2     
+ Misses       7073     7071    -2     
  Partials     1092     1092           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Love it! Cleans up our root directory and makes it easier to find all CircleCI related files.

👥 I'd like to get @cchensh's review before we merge this (once the corresponding PR is up to find these files).

@zimeg
Copy link
Member Author

zimeg commented Jun 6, 2025

@mwbrooks Heh thanks! I was most hopeful for this to be a welcomed change 🙏 ✨

I'll hold off on merging it for now and have opened a corresponding PR in the runner's repo but I cannot link it here! 🔗

In the meantime I am looking into signing builds for #114 - this is what motivated the update most! 🎁

@zimeg
Copy link
Member Author

zimeg commented Jun 9, 2025

@mwbrooks Thanks for reviewing! 👾 ✨

@cchensh and I are updating the runner now so I will merge this and test a code signing job with the latest updates 🫡

@zimeg zimeg merged commit cd32746 into main Jun 9, 2025
6 checks passed
@zimeg zimeg deleted the zimeg-ci-runner-dir branch June 9, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build M-T: Changes to compilation and CI processes code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants