build: share releases of feature tags for install from pull requests #125

zimeg · 2025-06-10T16:59:37Z

Summary

This PR updates the feature tag workflow to prefer building on branches of a pull request. 👾

Notes

Reasons and motivation for these changes will be commented below, but this unlocks testing changes of
build: sign macos binaries for arm and amd architectures and universal packagings #124 🤖 ✨

Requirements

I've read and understood the Contributing Guidelines and have done my best effort to follow them.
I've read and agree to the Code of Conduct.

codecov · 2025-06-10T17:01:59Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.49%. Comparing base (50e8223) to head (4964546).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   63.48%   63.49%   +0.01%     
==========================================
  Files         212      212              
  Lines       22344    22344              
==========================================
+ Hits        14184    14187       +3     
+ Misses       7078     7077       -1     
+ Partials     1082     1080       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

zimeg

💌 Sharing thoughts with the kind reviewers but I might revisit something before marking this for review!

zimeg · 2025-06-10T17:01:35Z

.circleci/config.yml

      - run:
          name: Output BUILD_VERSION env var based on recent git tag and type of build
          command: |
-            BUILD_VERSION=$(git describe --tags --match 'v*.*.*' --exclude '*feature');


👁️‍🗨️ Accepting the -feature suffix matches the description of collecting the build version, and matches the tag that goreleaser expects:

slack-cli/.circleci/config.yml

Line 23 in 12daa9a

description: "Exports a BUILD_VERSION env var based on the most recent git tag. The format of the string will be 'vX.X.X[-branch-name[-feature]]', unless the `sanitized` parameter is set to `true` which drops the `v` prefix."

.circleci/config.yml

zimeg · 2025-06-10T17:05:07Z

.circleci/config.yml

-                    --arg ct "$CIRCLE_TAG" \
-                    --arg cs "$CIRCLE_SHA1" \


🪓 These are unused in the upstream script!

Nice, thanks for removing them and simplifying the config!

zimeg · 2025-06-10T17:06:39Z

.github/workflows/delete-pr-build-on-close.yml

            sleep 1
+
+            FEATURE_TAG_NAME="${TAGS}-${REF}-feature"
+            echo "Identified feature-release tagname as 🔪: $FEATURE_TAG_NAME"


🪓 Here we attempt to delete feature releases after the corresponding PR merges into main with the feature branch deleted to prefer the "dev" build.

I'm not certain if we want to do this or if it should set RELEASE_FOUND to "0" 🤔

I can see both sides of the question. On one side, the feature release might be useful to folks even if it's merged and released. For example, falling back on a working feature build that has a bug in the production release. On the other hand, cleaning up development work (including feature tags) would be nice.

zimeg · 2025-06-10T17:16:04Z

🏁 Before pushing the feature tag, I will make sure tests of a PR pass with these changes. Then I will test the tag.

Then I'll push another commit to make sure nothing wild happens!

zimeg · 2025-06-10T17:36:16Z

📣 From the runner logs of a feature build the revert above seems to still checkout these changes fine:

Note: switching to '125f35207543780f639d4c52abd9e7ad7fd37d09'.

I'm also finding both the prerelease and feature tag appear as we hope:

zimeg · 2025-06-10T17:46:30Z

👻 Even with the preceding feature tag existing for 4964546 the prerelease uploads are still found on the branch release:

v3.3.0-zimeg-build-feature-tag-pull-request

Edit: Added the commit with the preceding feature tag!

mwbrooks

✅ Looking good and love the docs 📚

💬 Regarding your question around cleaning up the feature release, I think we can do either one. We may change our choice if we receive feedback from the community as well.

mwbrooks · 2025-06-10T18:58:20Z

.circleci/config.yml

-                    --arg ct "$CIRCLE_TAG" \
-                    --arg cs "$CIRCLE_SHA1" \


Nice, thanks for removing them and simplifying the config!

mwbrooks · 2025-06-10T18:59:24Z

.github/MAINTAINERS_GUIDE.md

+```bash
+curl -fsSL https://downloads.slack-edge.com/slack-cli/install-dev.sh | bash -s -- -v 3.4.5-feat-something-feature
+```


Ahhhh, so nice to have this documented! ✨

mwbrooks · 2025-06-10T19:01:10Z

.github/workflows/delete-pr-build-on-close.yml

            sleep 1
+
+            FEATURE_TAG_NAME="${TAGS}-${REF}-feature"
+            echo "Identified feature-release tagname as 🔪: $FEATURE_TAG_NAME"


I can see both sides of the question. On one side, the feature release might be useful to folks even if it's merged and released. For example, falling back on a working feature build that has a bug in the production release. On the other hand, cleaning up development work (including feature tags) would be nice.

zimeg · 2025-06-10T19:14:59Z

@mwbrooks Thanks for the review and unblocking downstream PRs! 🚀 ✨

On one side, the feature release might be useful to folks even if it's merged and released.

This was similar to what I was thinking about, in CI that might depend on certain features. We might lean into more more soon releases to bring those features to a stable version though, but I do understand how useful this might be 🙏

For now let's merge this - I'll keep watch on the feature tag linked above for proper deletion.

zimeg · 2025-06-10T19:17:13Z

📣 Sweet that's looking good too:

https://github.com/slackapi/slack-cli/actions/runs/15568258806/job/43837591542#step:2:81

Identified pre-release tagname to 🔪: v3.3.0-zimeg-build-feature-tag-pull-request
...
Successfully deleted v3.3.0-zimeg-build-feature-tag-pull-request
Identified feature-release tagname as 🔪: v3.3.0-zimeg-build-feature-tag-pull-request-feature
...
Successfully deleted v3.3.0-zimeg-build-feature-tag-pull-request-feature

build: share releases of feature tags from pull requests

12daa9a

zimeg added this to the Next Release milestone Jun 10, 2025

zimeg self-assigned this Jun 10, 2025

zimeg added semver:patch Use on pull requests to describe the release version increment build M-T: Changes to compilation and CI processes labels Jun 10, 2025

zimeg commented Jun 10, 2025

View reviewed changes

revert: do not remove the feature suffix of a tag for circleci runner

125f352

docs: remove the leading version prefix when installing via script

4964546

zimeg marked this pull request as ready for review June 10, 2025 17:50

zimeg requested a review from a team as a code owner June 10, 2025 17:50

mwbrooks approved these changes Jun 10, 2025

View reviewed changes

zimeg merged commit c64e342 into main Jun 10, 2025
6 checks passed

zimeg deleted the zimeg-build-feature-tag-pull-request branch June 10, 2025 19:15

build: share releases of feature tags for install from pull requests #125

build: share releases of feature tags for install from pull requests #125

Uh oh!

Conversation

zimeg commented Jun 10, 2025

Summary

Notes

Requirements

Uh oh!

codecov bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zimeg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zimeg commented Jun 10, 2025

Uh oh!

zimeg commented Jun 10, 2025

Uh oh!

zimeg commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mwbrooks left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zimeg commented Jun 10, 2025

Uh oh!

Uh oh!

zimeg commented Jun 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Jun 10, 2025 •

edited

Loading

zimeg commented Jun 10, 2025 •

edited

Loading