Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Jun 25, 2025

Summary

This PR removes guards that check if the bolt experiment is toggled on since this has been the default behavior for some time to build confidence 🤖

No change to functionalities! Related code not used with the bolt experiment was removed too 🪓

Reviewers

Run familiar commands to create and initialize a project:

$ slack create asdf  # Either Bolt or Deno
$ cd asdf
$ slack init

Requirements

@zimeg zimeg added this to the Next Release milestone Jun 25, 2025
@zimeg zimeg self-assigned this Jun 25, 2025
@zimeg zimeg requested a review from a team as a code owner June 25, 2025 05:06
@zimeg zimeg added code health M-T: Test improvements and anything that improves code health experiment Experimental feature accessed behind the --experiment flag or toggle semver:patch Use on pull requests to describe the release version increment labels Jun 25, 2025
@codecov
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

Attention: Patch coverage is 80.45977% with 17 lines in your changes missing coverage. Please review.

Project coverage is 63.37%. Comparing base (2484046) to head (f2dbb52).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/pkg/create/create.go 72.97% 10 Missing ⚠️
cmd/project/create_template.go 87.75% 3 Missing and 3 partials ⚠️
cmd/project/create.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
- Coverage   63.59%   63.37%   -0.22%     
==========================================
  Files         212      212              
  Lines       22398    22333      -65     
==========================================
- Hits        14244    14154      -90     
- Misses       7072     7094      +22     
- Partials     1082     1085       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zimeg zimeg modified the milestones: v3.5.0, Next Release Jun 27, 2025
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Looking good @zimeg!

🧪 Code looks good and I've tested locally. Let's merge it!

@zimeg
Copy link
Member Author

zimeg commented Jul 2, 2025

@mwbrooks Thanks so much! I'm feeling confident in these changes and hoping to remove more code soon so I will merge this now 🪓

@zimeg zimeg merged commit 3db7b97 into main Jul 2, 2025
6 checks passed
@zimeg zimeg deleted the zimeg-chore-experiment-bolt-removal branch July 2, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code health M-T: Test improvements and anything that improves code health experiment Experimental feature accessed behind the --experiment flag or toggle semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants