Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Jul 17, 2025

Summary

This PR defaults to using the bolt-install experiment behavior for app selection. No change to behavior.

Notes

This builds on changes from #158 and #159 to make upcoming changes to the test suite more clear 👁️‍🗨️ ✨

Requirements

@zimeg zimeg self-assigned this Jul 17, 2025
@zimeg zimeg added code health M-T: Test improvements and anything that improves code health experiment Experimental feature accessed behind the --experiment flag or toggle semver:patch Use on pull requests to describe the release version increment labels Jul 17, 2025
@codecov
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

Attention: Patch coverage is 78.94737% with 8 lines in your changes missing coverage. Please review.

Project coverage is 62.91%. Comparing base (c186ffc) to head (a4cc589).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/prompts/app_select.go 78.94% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
- Coverage   62.96%   62.91%   -0.05%     
==========================================
  Files         212      212              
  Lines       21592    21585       -7     
==========================================
- Hits        13595    13580      -15     
- Misses       6952     6957       +5     
- Partials     1045     1048       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zimeg zimeg marked this pull request as ready for review July 19, 2025 00:35
@zimeg zimeg requested a review from a team as a code owner July 19, 2025 00:35
@mwbrooks mwbrooks added this to the Next Release milestone Jul 21, 2025
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Very nice! The code changes look straight forward and manual testing works on Standalone Workspaces and Enterprise Organizations! 🎉

Base automatically changed from zimeg-refactor-app-select-join to main July 23, 2025 05:57
@zimeg
Copy link
Member Author

zimeg commented Jul 23, 2025

@mwbrooks Thank you! This has a most useful experiment to've had but I'm glad we can make this the default 🪓

Let's merge this PR now with plans to revisit creating apps when multiple exist for a team in later changes - excited for more experiments to soon follow as well 👾 ✨

@zimeg zimeg merged commit 2dbdf93 into main Jul 23, 2025
6 checks passed
@zimeg zimeg deleted the zimeg-chore-remove-bolt-install-experiment-app-select branch July 23, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code health M-T: Test improvements and anything that improves code health experiment Experimental feature accessed behind the --experiment flag or toggle semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants