-
Notifications
You must be signed in to change notification settings - Fork 24
chore: default to bolt-install experiment behavior for app selection #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: default to bolt-install experiment behavior for app selection #162
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
==========================================
- Coverage 62.96% 62.91% -0.05%
==========================================
Files 212 212
Lines 21592 21585 -7
==========================================
- Hits 13595 13580 -15
- Misses 6952 6957 +5
- Partials 1045 1048 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mwbrooks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Very nice! The code changes look straight forward and manual testing works on Standalone Workspaces and Enterprise Organizations! 🎉
|
@mwbrooks Thank you! This has a most useful experiment to've had but I'm glad we can make this the default 🪓 Let's merge this PR now with plans to revisit creating apps when multiple exist for a team in later changes - excited for more experiments to soon follow as well 👾 ✨ |
Summary
This PR defaults to using the
bolt-installexperiment behavior for app selection. No change to behavior.Notes
This builds on changes from #158 and #159 to make upcoming changes to the test suite more clear 👁️🗨️ ✨
--teamflag when multiple apps exist and the option to create is available.Example command:
trigger createIMHO testing related to this and changes to prompt behavior might wait for a follow up PR 🙏
slack-cli/internal/prompts/app_select.go
Lines 549 to 552 in 5b9f5ab
Requirements