Skip to content

Conversation

@mwbrooks
Copy link
Member

Summary

This pull request updates the MAINTAINERS_GUIDE.md with a troubleshooting step to add the $GOPATH/bin to your $PATH.

Preview MAINTAINERS_GUDIE.md

Honestly, I'm not sure what the best practice is here. The golangci-lint Installation Guide asks you to run a curl command that installs golangci-lint to your $(go env GOPATH)/bin. However, the default installation of Golang using the .pkg doesn't configure this path. I imagine this varies depending how Golang was installed, so I've decided to add this as a troubleshooting step.

Requirements

@mwbrooks mwbrooks added this to the Next Release milestone Jul 17, 2025
@mwbrooks mwbrooks self-assigned this Jul 17, 2025
@mwbrooks mwbrooks added docs M-T: Documentation work only semver:patch Use on pull requests to describe the release version increment labels Jul 17, 2025
@mwbrooks mwbrooks changed the title Mwbrooks setup update docs: Update MAINTAINERS_GUIDE.md with golangci-lint command not found Jul 17, 2025
@mwbrooks mwbrooks marked this pull request as ready for review July 17, 2025 23:44
@mwbrooks mwbrooks requested a review from a team as a code owner July 17, 2025 23:44
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwbrooks Ahh forbid be a golangci-lint not found error! Thanks for catching this 🙏 ✨

I left a comment unrelated to the troubleshooting, but I'm glad to know optimistic contributors won't be blocked from this 🤖

Comment on lines +129 to +131
```bash
export PATH=$PATH:$(go env GOPATH)/bin
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗣️ This makes me wish each a $HOME/bin or similar was standard for the $PATH...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:nod: I agree!

@mwbrooks
Copy link
Member Author

Thanks for the quick review @zimeg! 🙇🏻

@mwbrooks mwbrooks merged commit 988b1ca into main Jul 21, 2025
5 checks passed
@mwbrooks mwbrooks deleted the mwbrooks-setup-update branch July 21, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs M-T: Documentation work only semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants