feat: error if the runtime is not found with a missing hook

[zimeg]

Changelog

We added a new runtime_not_found error code that appears when a hook script cannot be found because the runtime for a project wasn't found during execution.

Summary

This PR errors with a runtime_not_found error if the hook runtime doesn't exist when a sdk_hook_not_found error is returned.

With this change, we make use of hook resolution and assume that if the runtime isn't set, that wasn't returned in the response from get-hooks.

In sample applications and with init we suggest gathering hook values from the get-hooks script and don't override the runtime value. IMO this is good for the happy path cases! Additional hook customizations might run into unexpected errors with a customized runtime but debugging information remains available in verbose outputs 👾

Preview

🔍 Errors when a hook is not found and the runtime doesn't exist follow:

🔍 Errors when a hook is found but errors, without a runtime, continue to error:

Reviewers

Uninstall various runtimes and attempt to interact with a matching app:

$ slack create asdf
$ cd asdf
$ slack manifest

Notes

• A follow up to not error if the get-hooks script errors is needed so that other hooks can still be parsed, if defined.

Requirements

• I've read and understood the Contributing Guidelines and have done my best effort to follow them.
• I've read and agree to the Code of Conduct.

[codecov]

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 63.08%. Comparing base (bed795a) to head (c466968).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/root.go	88.88%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   63.07%   63.08%           
=======================================
  Files         212      212           
  Lines       21667    21672    +5     
=======================================
+ Hits        13666    13671    +5     
+ Misses       6951     6950    -1     
- Partials     1050     1051    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[zimeg]

📝 Leaving a few notes for the kind reviewers!

[zimeg]

🔏 note: The runtime is unknown to actual hook scripts, so the runtime_not_found error can't be determined during hook execution itself...

🤔 question: Does this error handling logic make sense to include at the root command cleanup, or should hook executions be checked for this?

[zimeg]

🔍 note: Moved this since we now might update the err value!

[zimeg]

🗣️ note: This is followup in preparation for changes from #165!

[mwbrooks]

✅ Thanks for updating this! It's a very nice improvement to debug why a hook has failed.

🧪 Manual testing worked well - I tested using Deno. 🦕

[mwbrooks]

praise: I like that you've chosen to remove this very-specific hook error for the general ErrSDKHookNotFound and Remediation combination.

[zimeg]

thought: Once errors across packages are wrapped I'm optimistic these same details will be clear in output messages 🙏

[zimeg]

@mwbrooks And thanks for the kind review! 👁️‍🗨️ ✨

Let's merge this now but continue the efforts to improved hook debugging. I'm optimistic that #174 can be a next good step for troubleshooting steps.